-
Notifications
You must be signed in to change notification settings - Fork 762
docs: use prebuilt gpt-oss container #2313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1f85608 to
44e726a
Compare
WalkthroughThe documentation for GPT-OSS deployment was updated to recommend pulling a prebuilt container image instead of building one from scratch. A new environment variable for the image URL was introduced, along with a collapsible section that provides manual build instructions for different architectures. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
components/backends/trtllm/gpt-oss.md (1)
45-79: Minor build‐step inconsistencies
- The x86_64 snippet omits
--platform linux/amd64, which is helpful when building on non-x86 hosts (e.g. Apple M-series).- The two snippets reset
DYNAMO_CONTAINER_IMAGEto different names (…-arm64,…-amd64) but laterdocker runrelies on the value exported before the<details>block. Clarify that the subsequentdocker runexample assumes the pull workflow, or remind readers toexportthe new tag after a manual build.Consider:
-# Build x86_64 image -docker build -f container/Dockerfile.tensorrt_llm_prebuilt . \ +docker build --platform linux/amd64 -f container/Dockerfile.tensorrt_llm_prebuilt . \and add a note:
After building,
export DYNAMO_CONTAINER_IMAGE=<your custom tag>before continuing with Step 3.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/backends/trtllm/gpt-oss.md(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Mirror Repository to GitLab
- GitHub Check: pre-merge-rust (.)
- GitHub Check: Build and Test - vllm
Summary by CodeRabbit