-
Notifications
You must be signed in to change notification settings - Fork 753
feat: Add performance sweeps for DeepSeek R1 on GB200 #2387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5fb3fcf to
7ac08ee
Compare
components/backends/trtllm/performance_sweeps/scripts/gen_yaml.py
Outdated
Show resolved
Hide resolved
components/backends/trtllm/performance_sweeps/scripts/start_server.sh
Outdated
Show resolved
Hide resolved
rmccorm4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking thoughts for future
- Can
submit.shandsubmit_agg.shbe a single intuitive script? - If not, I think
submit_disagg.shandsubmit_agg.shwould be a bit more intuitive/symmetrical when scanning the names of the scripts. Not clear thatsubmit.shmeans disagg. - What's the minimum number of GB200 nodes do you need available to run the largest config used in the scripts?
- Can you add a note to the relevant README about your findings on performance impact of using
srun --exclusivesomewhere? - Do you see the submit*.sh scripts converging with the multinode scripts (ex:
srun_disaggregated.sh) for a single general purpose set?
I believe it would be too many configs in a single file.
Will rename it in the follow-up PR.
Will include in the notes.
Sure!
Yes. I have this in mind. Will look into refactoring in near future. |
Signed-off-by: Hannah Zhang <[email protected]>
Overview:
Declare these variables:
Run the disaggregated serving MTP0 sweeps with the following command:
For aggregated use the following:
Run post processing on performance numbers:
Summary by CodeRabbit
New Features
Documentation