Skip to content

cleanup #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanolson merged 4 commits into from
Aug 14, 2025
Merged

cleanup #2425

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57f8ac0
removing debug asserts which richard was likely not triggering
ryanolson Aug 13, 2025
601f6d0
Merge branch 'ryan/connector-dev' into ryan/connector-cleanup
ryanolson Aug 13, 2025
5737252
tightened up the constraint on slot existence; moved the abort check …
ryanolson Aug 13, 2025
37a2b03
new logic allows for a finished request to trigger while loading and …
ryanolson Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
removing debug asserts which richard was likely not triggering
  • Loading branch information
@ryanolson
ryanolson committed Aug 13, 2025
commit 57f8ac0f4fdc889c532f601d485b9acca3deb9e5
15 changes: 9 additions & 6 deletions lib/bindings/python/rust/llm/block_manager/vllm/connector/worker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,14 +301,17 @@ impl Worker for KvConnectorWorker {
for request_id in finished_requests {
tracing::debug!(request_id, "marking request as finished");

debug_assert!(
self.connector.has_slot(&request_id),
"request slot not found"
);
if !self.connector.has_slot(&request_id) {
tracing::warn!(
request_id,
"finished request received for unknown request_id; assuming never started"
);
continue;
}

debug_assert!(
assert!(
!self.maybe_finished_offloading.contains(&request_id),
"request already in maybe storing finished"
"request_id {request_id} already in maybe storing finished"
);

// insert request into the maybe finished set
Expand Down