Skip to content

fix: add fields documentation in CRDs #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienmancuso merged 2 commits into from
Aug 15, 2025
Merged

fix: add fields documentation in CRDs #2447

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8eb421
fix: add fields documentation in CRDs
julienmancuso Aug 14, 2025
eabdf69
fix: add fields documentation in CRDs
julienmancuso Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: add fields documentation in CRDs
  • Loading branch information
@julienmancuso
julienmancuso committed Aug 14, 2025
commit eabdf697054f01882231d098e1c5480903ce1b71
4 changes: 4 additions & 0 deletions deploy/cloud/helm/crds/templates/nvidia.com_dynamocomponentdeployments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10199,10 +10199,12 @@ spec:
type: string
type: object
gpu:
description: GPU is the number of GPUs to request per node.
type: string
memory:
type: string
nodes:
description: Nodes is the number of nodes to request. Total number of GPUs will be GPU * Nodes.
type: string
type: object
requests:
Expand All @@ -10214,10 +10216,12 @@ spec:
type: string
type: object
gpu:
description: GPU is the number of GPUs to request per node.
type: string
memory:
type: string
nodes:
description: Nodes is the number of nodes to request. Total number of GPUs will be GPU * Nodes.
type: string
type: object
type: object
Expand Down
4 changes: 4 additions & 0 deletions deploy/cloud/helm/crds/templates/nvidia.com_dynamographdeployments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10298,10 +10298,12 @@ spec:
type: string
type: object
gpu:
description: GPU is the number of GPUs to request per node.
type: string
memory:
type: string
nodes:
description: Nodes is the number of nodes to request. Total number of GPUs will be GPU * Nodes.
type: string
type: object
requests:
Expand All @@ -10313,10 +10315,12 @@ spec:
type: string
type: object
gpu:
description: GPU is the number of GPUs to request per node.
type: string
memory:
type: string
nodes:
description: Nodes is the number of nodes to request. Total number of GPUs will be GPU * Nodes.
type: string
type: object
type: object
Expand Down
8 changes: 5 additions & 3 deletions deploy/cloud/operator/api/dynamo/common/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@ import (
)

type ResourceItem struct {
CPU string `json:"cpu,omitempty"`
Memory string `json:"memory,omitempty"`
GPU string `json:"gpu,omitempty"`
CPU string `json:"cpu,omitempty"`
Memory string `json:"memory,omitempty"`
// GPU is the number of GPUs to request per node.
GPU string `json:"gpu,omitempty"`
// Nodes is the number of nodes to request. Total number of GPUs will be GPU * Nodes.
Nodes string `json:"nodes,omitempty"`
Custom map[string]string `json:"custom,omitempty"`
}
Expand Down
4 changes: 4 additions & 0 deletions deploy/cloud/operator/config/crd/bases/nvidia.com_dynamocomponentdeployments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10199,10 +10199,12 @@ spec:
type: string
type: object
gpu:
description: GPU is the number of GPUs to request per node.
type: string
memory:
type: string
nodes:
description: Nodes is the number of nodes to request. Total number of GPUs will be GPU * Nodes.
type: string
type: object
requests:
Expand All @@ -10214,10 +10216,12 @@ spec:
type: string
type: object
gpu:
description: GPU is the number of GPUs to request per node.
type: string
memory:
type: string
nodes:
description: Nodes is the number of nodes to request. Total number of GPUs will be GPU * Nodes.
type: string
type: object
type: object
Expand Down
4 changes: 4 additions & 0 deletions deploy/cloud/operator/config/crd/bases/nvidia.com_dynamographdeployments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10298,10 +10298,12 @@ spec:
type: string
type: object
gpu:
description: GPU is the number of GPUs to request per node.
type: string
memory:
type: string
nodes:
description: Nodes is the number of nodes to request. Total number of GPUs will be GPU * Nodes.
type: string
type: object
requests:
Expand All @@ -10313,10 +10315,12 @@ spec:
type: string
type: object
gpu:
description: GPU is the number of GPUs to request per node.
type: string
memory:
type: string
nodes:
description: Nodes is the number of nodes to request. Total number of GPUs will be GPU * Nodes.
type: string
type: object
type: object
Expand Down
Loading