Skip to content

Fix: Canonicalize PodGangSet to prevent spurious updates #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienmancuso merged 8 commits into from
Aug 18, 2025
Merged

Fix: Canonicalize PodGangSet to prevent spurious updates #2469

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8b81baf
fix: generate predictable PodSpec
julienmancuso Aug 15, 2025
1fedf80
fix: generate predictable PodSpec
julienmancuso Aug 15, 2025
feef55a
fix: generate predictable PodSpec
julienmancuso Aug 15, 2025
8e4c9a8
fix: generate predictable PodSpec
julienmancuso Aug 15, 2025
4ca0e0f
fix: generate predictable PodSpec
julienmancuso Aug 15, 2025
102f10b
fix: generate predictable PodSpec
julienmancuso Aug 15, 2025
3cbb106
fix: generate predictable PodSpec
julienmancuso Aug 15, 2025
3d9e979
fix: generate predictable PodSpec
julienmancuso Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: generate predictable PodSpec
  • Loading branch information
@julienmancuso
julienmancuso committed Aug 15, 2025
commit 3cbb1065eebb8cc57eda7ac365f7625d60725041
5 changes: 2 additions & 3 deletions deploy/cloud/operator/internal/dynamo/graph.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,8 +810,7 @@ func GenerateBasePodSpec(
podSpec.Volumes = append(podSpec.Volumes, volumes...)
podSpec.ImagePullSecrets = append(podSpec.ImagePullSecrets, imagePullSecrets...)
backend.UpdatePodSpec(&podSpec, numberOfNodes, role, component, serviceName)
// return controller_common.CanonicalizePodSpec(&podSpec), nil
return &podSpec, nil
return controller_common.CanonicalizePodSpec(&podSpec), nil
}

func setMetricsLabels(labels map[string]string, dynamoGraphDeployment *v1alpha1.DynamoGraphDeployment) {
Expand Down Expand Up @@ -950,7 +949,7 @@ func GenerateGrovePodGangSet(
gangSet.Spec.Template.PodCliqueScalingGroupConfigs = scalingGroups
}

return gangSet, nil
return controller_common.CanonicalizePodGangSet(gangSet), nil
}

func generateLabels(component *v1alpha1.DynamoComponentDeploymentOverridesSpec, dynamoDeployment *v1alpha1.DynamoGraphDeployment, componentName string) (map[string]string, error) {
Expand Down
Loading