Skip to content

fix: do not set default for resources #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienmancuso merged 7 commits into from
Aug 18, 2025
Merged

fix: do not set default for resources #2471

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6f93925
fix: do not set cpu/mem limit by default
julienmancuso Aug 16, 2025
20141a5
fix: do not set resources by default
julienmancuso Aug 18, 2025
3a658d6
fix: do not set resources by default
julienmancuso Aug 18, 2025
4b71d2b
fix: do not set resources by default
julienmancuso Aug 18, 2025
fb78e6a
fix: do not set resources by default
julienmancuso Aug 18, 2025
bef563c
fix: do not set resources by default
julienmancuso Aug 18, 2025
16868fc
fix: do not set resources by default
julienmancuso Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: do not set cpu/mem limit by default
  • Loading branch information
@julienmancuso
julienmancuso committed Aug 16, 2025
commit 6f9392500a31da6d5e990ee2352a11ac607f2609
4 changes: 3 additions & 1 deletion deploy/cloud/operator/internal/controller/dynamocomponentdeployment_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,9 @@ func TestDynamoComponentDeploymentReconciler_generateLeaderWorkerSet(t *testing.
Memory: "500Mi",
},
Limits: &common.ResourceItem{
GPU: "1",
GPU: "1",
Memory: "20Gi",
CPU: "10",
},
},
ExtraPodMetadata: &common.ExtraPodMetadata{
Expand Down
4 changes: 0 additions & 4 deletions deploy/cloud/operator/internal/dynamo/component_frontend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,6 @@ func (f *FrontendDefaults) GetBaseContainer(context ComponentContext) (corev1.Co
corev1.ResourceCPU: resource.MustParse("1"),
corev1.ResourceMemory: resource.MustParse("2Gi"),
},
Limits: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("1"),
corev1.ResourceMemory: resource.MustParse("2Gi"),
},
}

// Add standard environment variables
Expand Down
4 changes: 0 additions & 4 deletions deploy/cloud/operator/internal/dynamo/component_planner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ func (p *PlannerDefaults) GetBaseContainer(context ComponentContext) (corev1.Con
corev1.ResourceCPU: resource.MustParse("2"),
corev1.ResourceMemory: resource.MustParse("2Gi"),
},
Limits: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("2"),
corev1.ResourceMemory: resource.MustParse("2Gi"),
},
}

return container, nil
Expand Down
4 changes: 0 additions & 4 deletions deploy/cloud/operator/internal/dynamo/component_planner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,6 @@ func TestPlannerDefaults_GetBaseContainer(t *testing.T) {
corev1.ResourceCPU: resource.MustParse("2"),
corev1.ResourceMemory: resource.MustParse("2Gi"),
},
Limits: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("2"),
corev1.ResourceMemory: resource.MustParse("2Gi"),
},
},
Env: []corev1.EnvVar{
{Name: "DYN_NAMESPACE", Value: "dynamo-namespace"},
Expand Down
4 changes: 1 addition & 3 deletions deploy/cloud/operator/internal/dynamo/component_worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ func (w *WorkerDefaults) GetBaseContainer(context ComponentContext) (corev1.Cont
corev1.ResourceMemory: resource.MustParse("20Gi"),
},
Limits: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("10"),
corev1.ResourceMemory: resource.MustParse("20Gi"),
"nvidia.com/gpu": resource.MustParse("1"),
"nvidia.com/gpu": resource.MustParse("1"),
},
}

Expand Down
Loading