-
Notifications
You must be signed in to change notification settings - Fork 750
feat: FT Request Cancellation feature and test for 0.5.0 #2500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b869c74 to
77cae01
Compare
77cae01 to
681067e
Compare
681067e to
8f12b18
Compare
michaelfeil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks correct on a high level, something we would use. left some questions.
grahamking
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should address the Mutex in a follow-up PR.
Yes, DIS-569. |
keivenchang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for answering the questions and thanks for this feat!
Signed-off-by: Krishnan Prashanth <[email protected]>
Signed-off-by: nnshah1 <[email protected]>
Overview:
This is a side branch for checking in all the smaller Request Cancellation features and fixes and tests, and have everything merged into main before the next 0.5.0 code freeze.
Details:
Features and Fixes:
Tests:
Where should the reviewer start?
Recommend starting with
/docsupdates, and then the followings:Python cancellation support:
/lib/bindings/python/rust/tests/test_cancellationon how Python can cancel / be notified on cancellation./lib/bindings/python/rust/context.rsand/lib/bindings/python/rust/lib.rson the implementation.Rust child and parent context:
/lib/runtime/src/engine.rson how a child context is linked to a parent context./lib/runtime/src/pipeline/context.rsfor an example on how the interface at engine.rs is implemented.vLLM abort on cancel:
/components/backends/vllm/src/dynamo/vllm/handlers.pyon how requests are aborted in vLLM on cancel./tests/fault_tolerance/test_request_cancellation.pyfor the E2E tests on cancellation.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
N/A
Summary by CodeRabbit
New Features
Documentation
Tests