Skip to content

Conversation

@nv-anants
Copy link
Contributor

@nv-anants nv-anants commented Aug 21, 2025

Overview:

add trtllm known issue for al2023

ref: OPS-754

Summary by CodeRabbit

  • Documentation
    • Updated AWS support matrix: Amazon Linux 2023 x86_64 now marked “Supported*” with a clarifying footnote.
    • Added caution notes highlighting a known TensorRT-LLM issue when installed inside the AL2023 container via Python Wheels.
    • No changes to code, APIs, or runtime behavior.

Signed-off-by: Anant Sharma <[email protected]>
@nv-anants nv-anants marked this pull request as ready for review August 21, 2025 17:37
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 21, 2025

Walkthrough

Documentation update in docs/support_matrix.md: marks Amazon Linux 2023 x86_64 entries as “Supported*” and adds caution notes about a known TensorRT-LLM issue when installed inside AL2023 containers via Python Wheels. No code or API changes.

Changes

Cohort / File(s) Summary
Docs: Support matrix updates
docs/support_matrix.md
Changed AL2023 x86_64 status to “Supported*”; added caution blocks about TensorRT-LLM issue for Python Wheels in AL2023 containers; no runtime or API impact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

A nibble of notes in the matrix’s field,
An asterisk blooms—truth now revealed.
Beware the Wheels where TensorRT may trip,
Says the rabbit scribe with a careful quip.
Docs hop forward; code stays still—
Footnotes flutter, precise and chill. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
docs/support_matrix.md (2)

82-82: Clarify the asterisk and align naming with the caution (introduce AL2023).

  • The “Supported*” marker needs an explicit footnote/legend in this section to explain what the asterisk means.
  • Also, the caution below uses “AL2023” but the table doesn’t introduce that abbreviation. Consider adding “(AL2023)” in the Version column to keep terminology consistent.

Apply this minimal inline tweak:

-| **Amazon Linux**          | 2023        | x86_64           | Supported*   |
+| **Amazon Linux**          | 2023 (AL2023) | x86_64         | Supported*   |

And add a short footnote/legend after the table (example text; adjust as needed):

* Supported with known limitations specific to installing TensorRT-LLM via Python Wheels inside AL2023-based containers. See internal issue OPS-754 for details and workarounds.

85-87: Use standard admonition casing and make scope/workaround explicit.

  • Prefer GitHub’s canonical casing “[!CAUTION]” for consistency with other callouts.
  • The statement is vague (“makes effective environment setup challenging”). Recommend briefly stating scope and pointing to workarounds (e.g., prefer NGC runtime images or a non-AL2023 base) while referencing OPS-754.

Proposed wording:

-> [!Caution]
-> * There is a known issue with the TensorRT-LLM framework when installed within the AL2023 container via the Python Wheels which makes effective environment setup challenging.
+> [!CAUTION]
+> * Known issue: Installing TensorRT-LLM via Python Wheels inside AL2023-based containers can lead to setup problems. Until OPS-754 is resolved, consider using the official NGC runtime containers or a non-AL2023 base, or consult OPS-754 for workarounds.
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 41a617f and 1f07a7d.

📒 Files selected for processing (1)
  • docs/support_matrix.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Mirror Repository to GitLab
  • GitHub Check: Build and Test - dynamo

Signed-off-by: Anant Sharma <[email protected]>
@nv-anants nv-anants merged commit cc48dd3 into main Aug 21, 2025
12 of 13 checks passed
@nv-anants nv-anants deleted the anants/add-al2023 branch August 21, 2025 20:16
nv-anants added a commit that referenced this pull request Aug 21, 2025
nv-anants added a commit that referenced this pull request Aug 21, 2025
dmitry-tokarev-nv pushed a commit that referenced this pull request Aug 21, 2025
nv-anants added a commit that referenced this pull request Aug 21, 2025
hhzhang16 pushed a commit that referenced this pull request Aug 27, 2025
Signed-off-by: Anant Sharma <[email protected]>
Signed-off-by: Hannah Zhang <[email protected]>
nv-anants added a commit that referenced this pull request Aug 28, 2025
KrishnanPrash pushed a commit that referenced this pull request Sep 2, 2025
Signed-off-by: Anant Sharma <[email protected]>
Signed-off-by: Krishnan Prashanth <[email protected]>
nnshah1 pushed a commit that referenced this pull request Sep 8, 2025
Signed-off-by: Anant Sharma <[email protected]>
Signed-off-by: nnshah1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants