-
Notifications
You must be signed in to change notification settings - Fork 751
docs: add trtllm known issue for al2023 #2604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Anant Sharma <[email protected]>
WalkthroughDocumentation update in docs/support_matrix.md: marks Amazon Linux 2023 x86_64 entries as “Supported*” and adds caution notes about a known TensorRT-LLM issue when installed inside AL2023 containers via Python Wheels. No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/support_matrix.md (2)
82-82: Clarify the asterisk and align naming with the caution (introduce AL2023).
- The “Supported*” marker needs an explicit footnote/legend in this section to explain what the asterisk means.
- Also, the caution below uses “AL2023” but the table doesn’t introduce that abbreviation. Consider adding “(AL2023)” in the Version column to keep terminology consistent.
Apply this minimal inline tweak:
-| **Amazon Linux** | 2023 | x86_64 | Supported* | +| **Amazon Linux** | 2023 (AL2023) | x86_64 | Supported* |And add a short footnote/legend after the table (example text; adjust as needed):
* Supported with known limitations specific to installing TensorRT-LLM via Python Wheels inside AL2023-based containers. See internal issue OPS-754 for details and workarounds.
85-87: Use standard admonition casing and make scope/workaround explicit.
- Prefer GitHub’s canonical casing “[!CAUTION]” for consistency with other callouts.
- The statement is vague (“makes effective environment setup challenging”). Recommend briefly stating scope and pointing to workarounds (e.g., prefer NGC runtime images or a non-AL2023 base) while referencing OPS-754.
Proposed wording:
-> [!Caution] -> * There is a known issue with the TensorRT-LLM framework when installed within the AL2023 container via the Python Wheels which makes effective environment setup challenging. +> [!CAUTION] +> * Known issue: Installing TensorRT-LLM via Python Wheels inside AL2023-based containers can lead to setup problems. Until OPS-754 is resolved, consider using the official NGC runtime containers or a non-AL2023 base, or consult OPS-754 for workarounds.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/support_matrix.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Mirror Repository to GitLab
- GitHub Check: Build and Test - dynamo
Signed-off-by: Anant Sharma <[email protected]>
Signed-off-by: Anant Sharma <[email protected]>
Signed-off-by: Anant Sharma <[email protected]>
Signed-off-by: Anant Sharma <[email protected]>
Signed-off-by: Anant Sharma <[email protected]>
Signed-off-by: Anant Sharma <[email protected]> Signed-off-by: Hannah Zhang <[email protected]>
Signed-off-by: Anant Sharma <[email protected]>
Signed-off-by: Anant Sharma <[email protected]> Signed-off-by: Krishnan Prashanth <[email protected]>
Signed-off-by: Anant Sharma <[email protected]> Signed-off-by: nnshah1 <[email protected]>
Overview:
add trtllm known issue for al2023
ref: OPS-754
Summary by CodeRabbit