-
Notifications
You must be signed in to change notification settings - Fork 766
fix: deploy readme changes based on customer feedback #2645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
abce61f
making changes to deploy readme based on customer feedback
athreesh a59dfbc
fixed trtllm nvcr.io
athreesh 5d3df91
precommit
athreesh 3620d02
Merge branch 'main' into k8s-readme-feedback
athreesh 179090f
keeping image tag more broad
athreesh 2caabfe
Merge branch 'k8s-readme-feedback' of https://github.com/ai-dynamo/dy…
athreesh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ Each backend has deployment examples and configuration options: | |
|
|
||
| ```bash | ||
| # Set same namespace from platform install | ||
| export NAMESPACE=dynamo-cloud | ||
| export NAMESPACE=<your-namespace-name> | ||
|
|
||
| # Deploy any example (this uses vLLM with Qwen model using aggregated serving) | ||
| kubectl apply -f components/backends/vllm/deploy/agg.yaml -n ${NAMESPACE} | ||
|
|
@@ -49,6 +49,34 @@ kubectl port-forward svc/agg-vllm-frontend 8000:8000 -n ${NAMESPACE} | |
| curl http://localhost:8000/v1/models | ||
| ``` | ||
|
|
||
| ### Container Images | ||
|
|
||
| Before deploying, you'll need to specify which container images to use in the CRD. You have several options: | ||
|
|
||
| **Option 1: Use Public Images** | ||
| The easiest way is to use public images from the [NVIDIA NGC Catalog](https://catalog.ngc.nvidia.com/orgs/nvidia/teams/ai-dynamo/collections/ai-dynamo). Simply update the image field in your deployment YAML: | ||
|
|
||
| ```yaml | ||
| # In your deployment YAML: | ||
| image: nvcr.io/nvidia/ai-dynamo/vllm-runtime:0.4.0 # vLLM | ||
| image: nvcr.io/nvidia/ai-dynamo/sglang-runtime:0.4.0 # SGLang | ||
| image: nvcr.io/nvidia/ai-dynamo/tensorrtllm-runtime:0.4.0 # TensorRT-LLM | ||
| ``` | ||
|
|
||
| **Option 2: Build Your Own** | ||
| For customization or private deployments, build containers from source: | ||
|
|
||
| ```bash | ||
| # Build from source | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we point to container args to specify framework (vllm, sglang, trtllm) and target ( |
||
| ./container/build.sh | ||
|
|
||
| # Tag and push to your registry | ||
| docker tag dynamo-runtime:latest your-registry/dynamo-runtime:latest | ||
| docker push your-registry/dynamo-runtime:latest | ||
| ``` | ||
|
|
||
| > **Note**: We're working to update all example YAMLs to default to public images with `:latest` tags for easier deployment. | ||
|
|
||
| ## What's a DynamoGraphDeployment? | ||
|
|
||
| It's a Kubernetes Custom Resource that defines your inference pipeline: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.