Skip to content

Conversation

@dmitry-tokarev-nv
Copy link
Contributor

@dmitry-tokarev-nv dmitry-tokarev-nv commented Aug 26, 2025

Overview:

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Documentation
    • Updated the Build Dependency support matrix to list vLLM 0.10.1.1 and SGLang 0.5.0rc2 as supported versions.
    • Provides an up-to-date reference for verifying environment compatibility and selecting dependency versions during setup or upgrades.
    • Existing entries remain unchanged; no functional changes to the product.
    • Users relying on these runtimes can consult the matrix for current support status.

Signed-off-by: Dmitry Tokarev <[email protected]>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 26, 2025

Walkthrough

Adds two new entries (vLLM 0.10.1.1 and SGLang 0.5.0rc2) to the Build Dependency table in docs/support_matrix.md. No code or API changes.

Changes

Cohort / File(s) Summary
Docs: Support Matrix
docs/support_matrix.md
Added build dependency entries for vLLM 0.10.1.1 and SGLang 0.5.0rc2.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

I hop through rows of versioned lore,
Scribbling vLLM, SGLang—two more.
In tables neat I plant each seed,
A gardener of build-time need.
Thump-thump! The matrix now complete—
Carrots aligned, dependencies sweet. 🥕

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ac9665c and c3bdc4b.

📒 Files selected for processing (1)
  • docs/support_matrix.md (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: dmitry-tokarev-nv
PR: ai-dynamo/dynamo#2179
File: docs/support_matrix.md:61-63
Timestamp: 2025-07-30T00:34:35.810Z
Learning: In docs/support_matrix.md, the NIXL version difference between runtime dependencies (0.5.0) and build dependencies (0.4.0) is intentional and expected, not an error that needs to be corrected.
📚 Learning: 2025-07-30T00:34:35.810Z
Learnt from: dmitry-tokarev-nv
PR: ai-dynamo/dynamo#2179
File: docs/support_matrix.md:61-63
Timestamp: 2025-07-30T00:34:35.810Z
Learning: In docs/support_matrix.md, the NIXL version difference between runtime dependencies (0.5.0) and build dependencies (0.4.0) is intentional and expected, not an error that needs to be corrected.

Applied to files:

  • docs/support_matrix.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Mirror Repository to GitLab
  • GitHub Check: Build and Test - dynamo
🔇 Additional comments (1)
docs/support_matrix.md (1)

72-73: Action Required: Confirm vLLM and SGLang versions in NGC runtime images/CI

docs/support_matrix.md (lines 72–73):

  • vLLM 0.10.1.1 is an official PyPI release (exists=true); variants 0.10.1.post1/0.10.1.post2 are not published.
  • SGLang 0.5.0rc2 is an official PyPI release (exists=true); sglang-nightly 0.5.0rc2 is not published.
  • Please verify that our NGC runtime images and CI pipelines actually install and test against these exact versions. If they differ, update the table entries to match the precise tags we ship.
  • (Optional) Consider adding a brief note near “Important” (around line 75) stating that the listed versions are the minimum validated versions and may evolve alongside our NGC images (akin to the TensorRT-LLM disclaimer).

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dmitry-tokarev-nv dmitry-tokarev-nv merged commit 46175f5 into main Aug 28, 2025
13 of 14 checks passed
@dmitry-tokarev-nv dmitry-tokarev-nv deleted the dtokarev-support-matrix-main branch August 28, 2025 03:05
jasonqinzhou pushed a commit that referenced this pull request Aug 30, 2025
Signed-off-by: Dmitry Tokarev <[email protected]>
Signed-off-by: Jason Zhou <[email protected]>
michaelshin pushed a commit that referenced this pull request Sep 2, 2025
Signed-off-by: Dmitry Tokarev <[email protected]>
Signed-off-by: Michael Shin <[email protected]>
KrishnanPrash pushed a commit that referenced this pull request Sep 2, 2025
Signed-off-by: Dmitry Tokarev <[email protected]>
Signed-off-by: Krishnan Prashanth <[email protected]>
@coderabbitai coderabbitai bot mentioned this pull request Sep 5, 2025
nnshah1 pushed a commit that referenced this pull request Sep 8, 2025
Signed-off-by: Dmitry Tokarev <[email protected]>
Signed-off-by: nnshah1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants