Skip to content

feat(operator): mechanism for disabling imagePullSecrets discovery #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmonty12 merged 6 commits into from
Sep 18, 2025
Merged

feat(operator): mechanism for disabling imagePullSecrets discovery #3092

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e6b2983
add label and tests
tmonty12 Sep 16, 2025
ea5bc56
rename vars
tmonty12 Sep 17, 2025
2146fd4
add docs
tmonty12 Sep 17, 2025
48e4e05
rename test
tmonty12 Sep 17, 2025
c739847
consolidate var
tmonty12 Sep 17, 2025
931f314
Merge branch 'main' into tmonty12/dep-383-mechanism-disable-image-sec…
tmonty12 Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename vars 
Signed-off-by: tmontfort <[email protected]>
  • Loading branch information
@tmonty12
tmonty12 committed Sep 17, 2025
commit ea5bc56319871b29f448e708564d66b6cf66e91c
5 changes: 3 additions & 2 deletions deploy/cloud/operator/internal/dynamo/graph.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,10 +765,11 @@ func GenerateBasePodSpec(
maps.Copy(container.Resources.Limits, overrideResources.Limits)
}

disableDockerSecrets := component.Annotations[commonconsts.KubeAnnotationDisableImagePullSecretDiscovery]
disableImagePullSecretAnnotationValue := component.Annotations[commonconsts.KubeAnnotationDisableImagePullSecretDiscovery]
shouldDisableImagePullSecret := disableImagePullSecretAnnotationValue == commonconsts.KubeLabelValueTrue

imagePullSecrets := []corev1.LocalObjectReference{}
if disableDockerSecrets != commonconsts.KubeLabelValueTrue && secretsRetriever != nil && component.ExtraPodSpec != nil && component.ExtraPodSpec.MainContainer != nil && component.ExtraPodSpec.MainContainer.Image != "" {
if !shouldDisableImagePullSecret && secretsRetriever != nil && component.ExtraPodSpec != nil && component.ExtraPodSpec.MainContainer != nil && component.ExtraPodSpec.MainContainer.Image != "" {
secretsName, err := secretsRetriever.GetSecrets(namespace, component.ExtraPodSpec.MainContainer.Image)
if err == nil {
for _, secretName := range secretsName {
Expand Down