Skip to content

feat: Port vllm port allocator to Rust in bindings #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grahamking merged 4 commits into from
Sep 19, 2025
Merged

feat: Port vllm port allocator to Rust in bindings #3125

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8918be5
feat: Port vllm port allocator to Rust in bindings
grahamking Sep 18, 2025
c1752fc
Fix type hints
grahamking Sep 18, 2025
0828708
chore(multimodal): Port allocation using DistributedRuntime
grahamking Sep 19, 2025
e3cd070
Address comments
grahamking Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address comments 
Signed-off-by: Graham King <[email protected]>
  • Loading branch information
@grahamking
grahamking committed Sep 19, 2025
commit e3cd0706e42158f0e22448e7a9020557bc46ab2f
2 changes: 1 addition & 1 deletion components/backends/vllm/src/dynamo/vllm/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ async def init(runtime: DistributedRuntime, config: Config):
config, factory
)

# TODO Hack to get data, move this to registering in shared storage somewhere
# TODO Hack to get data, move this to registering in TBD
factory.set_num_gpu_blocks_all(vllm_config.cache_config.num_gpu_blocks)
factory.set_request_total_slots_all(vllm_config.scheduler_config.max_num_seqs)
factory.init_publish()
Expand Down
2 changes: 1 addition & 1 deletion components/backends/vllm/src/dynamo/vllm/ports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ async def allocate_and_reserve_port(
)
allocated_ports = await allocate_and_reserve_port_block(runtime, namespace, request)
if not allocated_ports:
raise RuntimeError("allocate_port_block returned no ports")
raise RuntimeError("Failed to allocate required ports")
return allocated_ports[0] # Return the single allocated port


Expand Down
Loading