Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
b00cc28
add sub component type
tmonty12 Sep 19, 2025
433c71e
add testing
tmonty12 Sep 19, 2025
11f9e59
planner using prometheus env var endpoint
tmonty12 Sep 22, 2025
8eb0665
planner uses subComponentType and testingt
tmonty12 Sep 23, 2025
ea84c64
use deployment validation error
tmonty12 Sep 23, 2025
0a71b68
add back copyright header
tmonty12 Sep 23, 2025
3ec215d
backwards compatibility with framework component name
tmonty12 Sep 23, 2025
411c02f
update pre deployment profiling to use subComponentType
tmonty12 Sep 24, 2025
c59dd08
small comments
tmonty12 Sep 24, 2025
8e5dfda
update planner manifest to remove prometheus svc and use subComponent…
tmonty12 Sep 24, 2025
69bc1a9
update sla planner deployment docs
tmonty12 Sep 24, 2025
7dc6696
fix doc link
tmonty12 Sep 24, 2025
752b4ac
update profiler config and fix ci
tmonty12 Sep 24, 2025
0761925
small fixes
tmonty12 Sep 24, 2025
51782ff
more small fixes
tmonty12 Sep 24, 2025
3cc6677
revert changes to profiler - will do so in follow on PR
tmonty12 Sep 24, 2025
88b4181
args not optional
tmonty12 Sep 24, 2025
4da6983
small docs update
tmonty12 Sep 24, 2025
20504a2
properly parse prometheus metrics
tmonty12 Sep 26, 2025
3661f5d
fix ci
tmonty12 Sep 26, 2025
74e054c
fix virtual_connector
tmonty12 Sep 26, 2025
823327d
fix mypy
tmonty12 Sep 26, 2025
2c85f2d
remove prometheus server
tmonty12 Sep 26, 2025
0b54bca
pc
tedzhouhk Sep 26, 2025
15d524e
add subComponentType, remove prometheus installation, remove service …
tmonty12 Sep 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use deployment validation error
Signed-off-by: tmontfort <[email protected]>
  • Loading branch information
tmonty12 committed Sep 26, 2025
commit ea84c64cfec70354dc7e40084a109b996f6d2a8a
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def __init__(self, dynamo_namespace: str, k8s_namespace: Optional[str] = None):

graph_deployment_name = os.getenv("DYN_PARENT_DGD_K8S_NAME")
if not graph_deployment_name:
raise ValueError("DYN_PARENT_DGD_K8S_NAME environment variable is not set")
raise DeploymentValidationError(["DYN_PARENT_DGD_K8S_NAME environment variable is not set"])

self.graph_deployment_name = graph_deployment_name

Expand Down
5 changes: 4 additions & 1 deletion components/planner/test/kubernetes_connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,12 @@ def kubernetes_connector(mock_kube_api_class, monkeypatch):
return connector

def test_kubernetes_connector_no_env_var():
with pytest.raises(ValueError, match="DYN_PARENT_DGD_K8S_NAME environment variable is not set"):
with pytest.raises(DeploymentValidationError) as exc_info:
KubernetesConnector("test-dynamo-namespace", "default")

exception = exc_info.value
assert set(exception.errors) == {"DYN_PARENT_DGD_K8S_NAME environment variable is not set"}

def test_get_service_name_from_sub_component_type(kubernetes_connector):
deployment = {
"metadata": {"name": "test-graph"},
Expand Down