Skip to content

refactor: kvbm modularity DIS-657 Eliminate ETCD from the leader-worker initialization #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardhuo-nv merged 5 commits into from
Oct 23, 2025
Merged

refactor: kvbm modularity DIS-657 Eliminate ETCD from the leader-worker initialization #3202

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a68a22
remove etcd into kvbm leader-worker
richardhuo-nv Sep 24, 2025
f84da6a
resolve comments
richardhuo-nv Oct 2, 2025
37189e7
resolve fmt
richardhuo-nv Oct 2, 2025
4c477c8
fix
richardhuo-nv Oct 7, 2025
85cf9aa
doc update
richardhuo-nv Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
resolve fmt 
Signed-off-by: richardhuo-nv <[email protected]>
  • Loading branch information
@richardhuo-nv
richardhuo-nv committed Oct 22, 2025
commit 37189e7122d40d55840d54fe20fa6d96d1d7a1c6
4 changes: 3 additions & 1 deletion lib/llm/src/block_manager/distributed/leader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ impl KvbmLeaderConfig {

pub fn sanity_check(&self) -> anyhow::Result<()> {
if self.leader_pub_url == self.leader_ack_url {
anyhow::bail!("leader_pub_url and leader_ack_url must differ (same endpoint would fail to bind).");
anyhow::bail!(
"leader_pub_url and leader_ack_url must differ (same endpoint would fail to bind)."
);
}
let cpu = &self.host_blocks_config;
let disk = &self.disk_blocks_config;
Expand Down