Skip to content

fix: Send last token batch when finish_reason is set #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmccorm4 merged 2 commits into from
Oct 10, 2025
Merged

fix: Send last token batch when finish_reason is set #3531

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e71433
fix: Send last token when finish_reason is set
rmccorm4 Oct 9, 2025
609b9af
Address Guan's feedback - handle no finish_reason + no outputs scenar…
rmccorm4 Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions components/src/dynamo/sglang/request_handlers/llm/decode_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,26 +164,24 @@ async def _process_token_stream(

Yields:
Dict with token_ids and optional finish_reason.

Raises:
ValueError: If response missing output_ids.
"""
num_output_tokens_so_far = 0

async for res in stream_source:
out = {}
finish_reason = res["meta_info"]["finish_reason"]
if finish_reason:
out = {"token_ids": [], "finish_reason": finish_reason["type"]}
else:
try:
next_total_toks = len(res["output_ids"])
except KeyError:
raise ValueError(
f"Missing 'output_ids' in response. Response keys: {list(res.keys())}"
)
out = {"token_ids": res["output_ids"][num_output_tokens_so_far:]}
num_output_tokens_so_far = next_total_toks
out["finish_reason"] = finish_reason["type"]

output_ids = res.get("output_ids", [])
# If request is not finished yet, but there are no outputs, return an error.
if not output_ids and not finish_reason:
yield {"finish_reason": "error", "token_ids": []}
break

next_total_toks = len(output_ids)
out["token_ids"] = output_ids[num_output_tokens_so_far:]
num_output_tokens_so_far = next_total_toks
yield out

async def _process_text_stream(
Expand Down
Loading