Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
f427a8b
feat: Add automated dependency version tracking and extraction
Oct 10, 2025
7ea0b89
Add SPDX copyright header to extraction script
Oct 10, 2025
62b6e1f
Fix pre-commit issues: import order and EOF
Oct 10, 2025
b283998
Remove unintended files and update .gitignore
Oct 10, 2025
692b308
Fix pre-commit issues: executable permission and unused variables
Oct 10, 2025
318f45c
Fix remaining unused variables: service and critical_reason
Oct 10, 2025
51af209
Make baseline dependency count dynamic based on previous extraction
Oct 10, 2025
749d8e2
Add removed dependencies tracking and PR reporting
dagil-nvidia Oct 10, 2025
cc3c88f
Fix YAML syntax error in nightly workflow
dagil-nvidia Oct 10, 2025
d520194
Fix all pre-commit issues: YAML syntax and formatting
dagil-nvidia Oct 10, 2025
9ac63de
Fix shell script extraction to skip runtime-determined versions
dagil-nvidia Oct 10, 2025
c0722d0
feat: Enhance dependency extraction to capture pip installs and binar…
dagil-nvidia Oct 13, 2025
3b0e8ab
fix: Remove trailing whitespace from extraction script
dagil-nvidia Oct 13, 2025
bd37921
fix: address CodeRabbit and reviewer feedback
dagil-nvidia Oct 14, 2025
e4619f1
Address nv-tusharma's review comments
dagil-nvidia Oct 17, 2025
f5a8770
feat(deps): add version discrepancy detection and composite action
dagil-nvidia Oct 20, 2025
3b5a644
fix: apply black and ruff formatting fixes
dagil-nvidia Oct 20, 2025
5ff3749
fix(deps): improve discrepancy detection accuracy
dagil-nvidia Oct 20, 2025
f547bae
fix(deps): skip sub-dependency ARGs, normalize pinning, and document …
dagil-nvidia Oct 20, 2025
a1860f0
fix: apply isort and black formatting
dagil-nvidia Oct 20, 2025
3972458
feat(deps): add automated failure monitoring for dependency extractio…
dagil-nvidia Oct 20, 2025
a86a3f5
fix: address pre-commit trailing whitespace issues
dagil-nvidia Oct 21, 2025
e91ff3e
refactor(deps): address nv-anants review feedback
dagil-nvidia Oct 21, 2025
acc4450
docs(deps): add comprehensive documentation for dependency extraction
dagil-nvidia Oct 21, 2025
b98d2cf
chore: trigger DCO re-check
dagil-nvidia Oct 21, 2025
f041e40
refactor(deps): modularize dependency extraction system
dagil-nvidia Oct 22, 2025
32456dc
feat(deps): add extractor architecture and unit tests
dagil-nvidia Oct 22, 2025
512c347
Merge branch 'main' into feature/dependency-extraction-DYN-1235
dagil-nvidia Oct 22, 2025
c163fa4
fix: apply pre-commit formatting fixes and update test markers
dagil-nvidia Oct 22, 2025
d20b575
feat(deps): add dynamic FRAMEWORK_VERSIONS.md generator
dagil-nvidia Oct 22, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(deps): address nv-anants review feedback
Implemented review comments from PR #3547:

1. **Clarified gitignore patterns** - Added detailed comments explaining why timestamped CSVs are ignored while latest/release versions are tracked

2. **Merged unversioned dependencies into main CSV** - Removed separate unversioned_dependencies.csv file. All dependencies (versioned and unversioned) now in single CSV with console warnings for unversioned ones

3. **Moved config file** - Relocated extract_dependency_versions_config.yaml to .github/dependency-extraction/config.yaml for better organization outside workflows folder

4. **Merged nightly/release workflows** - Combined dependency-extraction-nightly.yml and dependency-extraction-release.yml into single unified dependency-extraction.yml with conditional logic based on trigger type

5. **Enhanced composite action** - Expanded dependency-extraction-setup action to include checkout, reports directory creation, and configurable fetch-depth

Changes:
- Updated all references to new config path
- Removed --report-unversioned flag from script and workflows
- Added unversioned dependency summary in write_csv() console output
- Unified workflow supports both nightly (schedule/manual) and release (push to release/* or manual) modes
- Composite action now handles more common setup steps

Documentation updated:
- README.md now references unified workflow
- PR description updated with comprehensive review details

Signed-off-by: Dan Gil <[email protected]>
  • Loading branch information
dagil-nvidia committed Oct 21, 2025
commit e91ff3ecd808142c1749dd42b48b33cc0b29b1f7
13 changes: 13 additions & 0 deletions .github/actions/dependency-extraction-setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,19 @@ inputs:
description: 'Python version to use'
required: false
default: '3.12'
fetch-depth:
description: 'Depth for git checkout (0 for full history, 1 for shallow)'
required: false
default: '0'

runs:
using: "composite"
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: ${{ inputs.fetch-depth }}

- name: Set up Python
uses: actions/setup-python@v5
with:
Expand All @@ -33,3 +42,7 @@ runs:
shell: bash
run: pip install pyyaml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be extended to extract more things out of workflow i think

- name: Create reports directory
shell: bash
run: mkdir -p .github/reports

7 changes: 3 additions & 4 deletions .github/reports/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ Critical dependencies are flagged in the CSV to highlight components that requir
- Production stability
- Compliance requirements

The list of critical dependencies is **explicitly maintained** in `../workflows/extract_dependency_versions_config.yaml` under the `critical_dependencies` section. Only dependencies listed in this configuration file are marked as critical. Examples include:
The list of critical dependencies is **explicitly maintained** in `../dependency-extraction/config.yaml` under the `critical_dependencies` section. Only dependencies listed in this configuration file are marked as critical. Examples include:
- CUDA (compute platform)
- PyTorch (ML framework)
- TensorRT-LLM (inference framework)
Expand Down Expand Up @@ -128,6 +128,5 @@ python3 .github/workflows/extract_dependency_versions.py --help
## Links

- πŸ€– [Extraction Script](../workflows/extract_dependency_versions.py)
- βš™οΈ [Configuration](../workflows/extract_dependency_versions_config.yaml)
- πŸ“‹ [Nightly Workflow](../workflows/dependency-extraction-nightly.yml)
- πŸ“Έ [Release Workflow](../workflows/dependency-extraction-release.yml)
- βš™οΈ [Configuration](../dependency-extraction/config.yaml)
- πŸ”„ [Unified Workflow](../workflows/dependency-extraction.yml) (handles both nightly and release)
235 changes: 0 additions & 235 deletions .github/workflows/dependency-extraction-nightly.yml

This file was deleted.

Loading