Skip to content

refactor: move engine configs out of components directory #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nv-anants merged 12 commits into from
Oct 24, 2025
Merged

refactor: move engine configs out of components directory #3772

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
95a7fbe
refactor: move engine configs out of components directory
nv-anants Oct 21, 2025
1c51164
fix multi node files
nv-anants Oct 21, 2025
d2fcf83
copy paste fix
nv-anants Oct 21, 2025
126ccd4
fix
nv-anants Oct 21, 2025
b14ec27
move remaining recipes
tanmayv25 Oct 22, 2025
10a8aac
Merge branch 'main' into reorg/trtllm-configs
nv-anants Oct 23, 2025
c499173
rabbit
nv-anants Oct 23, 2025
d9d40d2
more rabbit
nv-anants Oct 23, 2025
232e642
Merge branch 'main' into reorg/trtllm-configs
nv-anants Oct 23, 2025
260ec35
Merge branch 'main' into reorg/trtllm-configs
nv-anants Oct 23, 2025
bc55e48
Merge branch 'main' into reorg/trtllm-configs
nv-anants Oct 24, 2025
42bd2df
add recipes to docker
nv-anants Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more rabbit 
Signed-off-by: Anant Sharma <[email protected]>
  • Loading branch information
@nv-anants
nv-anants committed Oct 23, 2025
commit d9d40d280ee8caf1d462c03cc77344523dda3096
2 changes: 1 addition & 1 deletion docs/kubernetes/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ args:
- python3 -m dynamo.trtllm
--model-path deepseek-ai/DeepSeek-R1-Distill-Llama-8B
--served-model-name deepseek-ai/DeepSeek-R1-Distill-Llama-8B
--extra-engine-args $DYNAMO_HOME/recipes/deepseek-r1-distill-llama-8b/agg.yaml
--extra-engine-args /workspace/recipes/deepseek-r1-distill-llama-8b/agg.yaml
```

Key customization points include:
Expand Down
4 changes: 2 additions & 2 deletions examples/basics/multinode/trtllm/srun_aggregated.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ srun \
--nodelist "${HEAD_NODE}" \
--nodes 1 \
--jobid "${SLURM_JOB_ID}" \
/mnt/examples/multimodal/scripts/start_frontend_services.sh &
/mnt/examples/basics/multinode/trtllm/start_frontend_services.sh &

# NOTE: Output streamed to stdout for ease of understanding the example, but
# in practice you would probably set `srun --output ... --error ...` to pipe
Expand All @@ -71,4 +71,4 @@ srun \
--nodes "${NUM_NODES}" \
--ntasks-per-node "${NUM_GPUS_PER_NODE}" \
--jobid "${SLURM_JOB_ID}" \
/mnt/examples/multimodal/scripts/start_trtllm_worker.sh &
/mnt/examples/basics/multinode/trtllm/start_trtllm_worker.sh &
6 changes: 3 additions & 3 deletions examples/basics/multinode/trtllm/srun_disaggregated.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ srun \
--nodelist "${HEAD_NODE}" \
--nodes 1 \
--jobid "${SLURM_JOB_ID}" \
/mnt/examples/multimodal/scripts/start_frontend_services.sh &
/mnt/examples/basics/multinode/trtllm/start_frontend_services.sh &

# NOTE: Output streamed to stdout for ease of understanding the example, but
# in practice you would probably set `srun --output ... --error ...` to pipe
Expand All @@ -78,7 +78,7 @@ for ((i=1; i<=${NUM_PREFILL_WORKERS}; i++)); do
--nodes "${NUM_PREFILL_NODES}" \
--ntasks-per-node "${NUM_GPUS_PER_NODE}" \
--jobid "${SLURM_JOB_ID}" \
/mnt/examples/multimodal/scripts/start_trtllm_worker.sh &
/mnt/examples/basics/multinode/trtllm/start_trtllm_worker.sh &
done

for ((i=1; i<=${NUM_DECODE_WORKERS}; i++)); do
Expand All @@ -98,5 +98,5 @@ for ((i=1; i<=${NUM_DECODE_WORKERS}; i++)); do
--nodes "${NUM_DECODE_NODES}" \
--ntasks-per-node "${NUM_GPUS_PER_NODE}" \
--jobid "${SLURM_JOB_ID}" \
/mnt/examples/multimodal/scripts/start_trtllm_worker.sh &
/mnt/examples/basics/multinode/trtllm/start_trtllm_worker.sh &
done
Loading