fix: implementation of service discovery that uses the key value store manager #4091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mohammedabdulwahhab <[email protected]>
Signed-off-by: mohammedabdulwahhab <[email protected]>
mohammedabdulwahhab
changed the title
| tokio::sync::mpsc::Receiver<WatchEvent>, | ||
| ) { | ||
| let bucket_name = bucket_name.to_string(); | ||
| let (tx, rx) = tokio::sync::mpsc::channel(128); |
Contributor
Author
There was a problem hiding this comment.
This changes on this file are still a WIP and might not be needed at all. I am still evaluating by testing the ETCD implementation. Please omit from review if you are taking an early look
| ); | ||
|
|
||
| // Use the KeyValueStoreManager's watch mechanism | ||
| let (_, mut rx) = self.store.clone().watch( |
Contributor
Author
There was a problem hiding this comment.
A limitation of the APIs exposed by KeyValueBucket and KeyValueStoreManager is that we can only watch on the whole bucket (not a subset of keys). Technically, we can do this right now, but it would be going around the abstraction
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines an implementation of service discovery that uses the key value store manager