Skip to content

Conversation

@nv-oviya
Copy link
Contributor

@nv-oviya nv-oviya commented Nov 26, 2025

Overview:

Remove duplicate key causing ruff to fail.

Details:

Remove duplicate key 31 from XID_MESSAGES dictionary in gpu_xid_injector.py. Key 31 was defined twice:

  • Line 92: "MMU Error" (Memory Subsystem section)
  • Line 113: "GPU stopped responding" (Graphics section)

Removed the duplicate from Graphics section as the MMU Error definition is the primary meaning and the comment indicated it can be both contexts.

Fixes ruff pre-commit error: F601 Dictionary key literal 31 repeated

Where should the reviewer start?

  • Line 92 of gpu_xid_injector.py (XID_MESSAGES dictionary)

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Summary by CodeRabbit

  • Tests
    • Updated GPU fault injection test infrastructure to simplify error handling for certain failure scenarios.

Note: This is an internal technical change with no direct impact on user-facing functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

Remove duplicate key 31 from XID_MESSAGES dictionary in gpu_xid_injector.py.
Key 31 was defined twice:
- Line 92: "MMU Error" (Memory Subsystem section)
- Line 113: "GPU stopped responding" (Graphics section)

Removed the duplicate from Graphics section as the MMU Error definition
is the primary meaning and the comment indicated it can be both contexts.

Fixes ruff pre-commit error: F601 Dictionary key literal `31` repeated
Signed-off-by: Oviya Seeniraj <[email protected]>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 26, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@nv-oviya nv-oviya changed the title Fix duplicate dictionary key 31 in XID_MESSAGES fix: duplicate dictionary key 31 in XID_MESSAGES Nov 26, 2025
@github-actions github-actions bot added the fix label Nov 26, 2025
@nv-oviya nv-oviya marked this pull request as ready for review November 26, 2025 23:02
@nv-oviya nv-oviya requested review from a team as code owners November 26, 2025 23:02
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 26, 2025

Walkthrough

A dictionary entry mapping XID 31 ("GPU stopped responding") was removed from the XID_MESSAGES mapping in the GPU fault injector module. This change causes XID 31 errors to fall back to a generic error message format rather than displaying a dedicated description.

Changes

Cohort / File(s) Summary
XID Error Message Configuration
tests/fault_tolerance/hardware/fault-injection-service/agents/gpu-fault-injector/gpu_xid_injector.py
Removed XID 31 entry ("GPU stopped responding") from XID_MESSAGES dictionary; error will now use generic format

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

This is a straightforward dictionary entry removal with no logic changes or side effects to verify.

Poem

🐰 A message map grows lighter still,
One entry bid farewell with will,
XID 31 hops away,
To generic lands it goes to stay! ✨

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing a duplicate dictionary key 31 from XID_MESSAGES, which is the primary purpose of this PR.
Description check ✅ Passed The description includes all required sections from the template: Overview, Details, Where should the reviewer start, and Related Issues. It provides comprehensive context about the duplicate key issue and the rationale for removal.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e6bb7b and 0250436.

📒 Files selected for processing (1)
  • tests/fault_tolerance/hardware/fault-injection-service/agents/gpu-fault-injector/gpu_xid_injector.py (0 hunks)
💤 Files with no reviewable changes (1)
  • tests/fault_tolerance/hardware/fault-injection-service/agents/gpu-fault-injector/gpu_xid_injector.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build and Test - dynamo

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nv-oviya nv-oviya merged commit d52f070 into main Nov 26, 2025
12 of 13 checks passed
@nv-oviya nv-oviya deleted the fix/duplicate-xid-key-31 branch November 26, 2025 23:29
zxue2 pushed a commit to zxue2/dynamo that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants