-
Notifications
You must be signed in to change notification settings - Fork 742
fix: duplicate dictionary key 31 in XID_MESSAGES #4649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove duplicate key 31 from XID_MESSAGES dictionary in gpu_xid_injector.py. Key 31 was defined twice: - Line 92: "MMU Error" (Memory Subsystem section) - Line 113: "GPU stopped responding" (Graphics section) Removed the duplicate from Graphics section as the MMU Error definition is the primary meaning and the comment indicated it can be both contexts. Fixes ruff pre-commit error: F601 Dictionary key literal `31` repeated Signed-off-by: Oviya Seeniraj <[email protected]>
WalkthroughA dictionary entry mapping XID 31 ("GPU stopped responding") was removed from the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes This is a straightforward dictionary entry removal with no logic changes or side effects to verify. Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Oviya Seeniraj <[email protected]>
Overview:
Remove duplicate key causing ruff to fail.
Details:
Remove duplicate key 31 from XID_MESSAGES dictionary in gpu_xid_injector.py. Key 31 was defined twice:
Removed the duplicate from Graphics section as the MMU Error definition is the primary meaning and the comment indicated it can be both contexts.
Fixes ruff pre-commit error: F601 Dictionary key literal
31repeatedWhere should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
Note: This is an internal technical change with no direct impact on user-facing functionality.
✏️ Tip: You can customize this high-level summary in your review settings.