-
Notifications
You must be signed in to change notification settings - Fork 738
feat: Standalone encoder in dynamo trtllm #4668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
3438e07
9d831c8
86a2b46
6b58e80
60faba0
0fb6e95
fa7136e
2d6a358
8e60929
ae9b10b
fdb86d3
9ccb564
6101937
1f152c0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
Signed-off-by: Indrajit Bhosale <[email protected]>
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,7 +46,7 @@ def decode( | |
| multimodal_embedding_handles=getattr( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe stupid question: these already default to Why not use: dataclasses.replace(disaggregated_params, opaque_state=opaque_state)since Similar question for the |
||
| disaggregated_params, "multimodal_embedding_handles", None | ||
| ), | ||
| multimodal_hashes=getattr(disaggregated_params, "multimodal_hashes", None), | ||
| multimodal_hashes=getattr(disaggregated_params, "multimodal_hashes", None), | ||
| ) | ||
|
|
||
| @staticmethod | ||
|
|
@@ -73,5 +73,5 @@ def encode( | |
| draft_tokens=disaggregated_params.draft_tokens, | ||
| # E-P Disaggregated Params (for full EPD flow) | ||
| multimodal_embedding_handles=mm_handles, | ||
| multimodal_hashes=mm_hashes, | ||
| multimodal_hashes=mm_hashes, | ||
| ) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why not forward the rest of the
self.engine_args?MultimodalEncoderis also aLLMclass: https://github.com/NVIDIA/TensorRT-LLM/blob/v1.2.0rc4/tensorrt_llm/llmapi/mm_encoder.py#L16