-
Notifications
You must be signed in to change notification settings - Fork 738
fix: relax pydantic requirements #4865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dmitry Tokarev <[email protected]>
WalkthroughA single dependency constraint update in the requirements file loosens the pydantic upper version bound from 2.12 to 2.13, with an accompanying comment modification to reflect the rationale for this change. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-11-14T03:26:06.160ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…fixes Signed-off-by: Dmitry Tokarev <[email protected]>
Signed-off-by: Dmitry Tokarev <[email protected]>
Signed-off-by: Dmitry Tokarev <[email protected]>
nv-anants
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to bump here as well? - https://github.com/ai-dynamo/dynamo/blob/main/lib/bindings/python/pyproject.toml#L29
Signed-off-by: Dmitry Tokarev <[email protected]>
Overview:
This PR should fix this conflict:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.