Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Feb 5, 2025

changelog: pypa/packaging@24.1...24.2

I am hoping this fixes the twine check failures we see on 3.11

changelog: pypa/packaging@24.1...24.2

I am hoping this fixes the twine check failures we see on 3.11
@bdraco
Copy link
Member Author

bdraco commented Feb 5, 2025

🤞
Maybe pypa/packaging#828 has fixed it

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Feb 5, 2025
@bdraco bdraco marked this pull request as ready for review February 5, 2025 01:54
@bdraco bdraco enabled auto-merge (squash) February 5, 2025 01:55
@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (ac895b8) to head (e48f3bd).
Report is 67 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11   #10383   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         123      123           
  Lines       37228    37228           
  Branches     4477     4477           
=======================================
  Hits        36510    36510           
  Misses        540      540           
  Partials      178      178           
Flag Coverage Δ
CI-GHA 97.96% <ø> (ø)
OS-Linux 97.66% <ø> (+<0.01%) ⬆️
OS-Windows 94.70% <ø> (+<0.01%) ⬆️
OS-macOS 96.78% <ø> (ø)
Py-3.10.11 96.64% <ø> (+<0.01%) ⬆️
Py-3.10.16 97.21% <ø> (ø)
Py-3.11.11 97.23% <ø> (-0.01%) ⬇️
Py-3.11.9 96.71% <ø> (+0.01%) ⬆️
Py-3.12.8 97.71% <ø> (+0.02%) ⬆️
Py-3.13.1 97.71% <ø> (ø)
Py-3.9.13 96.56% <ø> (ø)
Py-3.9.21 97.12% <ø> (ø)
Py-pypy7.3.16 96.70% <ø> (+<0.01%) ⬆️
VM-macos 96.78% <ø> (ø)
VM-ubuntu 97.66% <ø> (+<0.01%) ⬆️
VM-windows 94.70% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #10383 will not alter performance

Comparing bump_packaging (e48f3bd) with 3.11 (ac895b8)

Summary

✅ 47 untouched benchmarks

@bdraco bdraco merged commit e38ea32 into 3.11 Feb 5, 2025
33 checks passed
@bdraco bdraco deleted the bump_packaging branch February 5, 2025 02:04
@webknjaz
Copy link
Member

webknjaz commented Feb 5, 2025

Oh yeah, it's a known thing that metadata 2.4 requires newer packaging in twine. Even though setuptools doesn't yet implement license expression...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants