Skip to content

Conversation

@Cycloctane
Copy link
Member

What do these changes do?

update-pre-commit is broken after #5261 due to the incorrect github.repository_owner condition. (See https://github.com/aio-libs/aiohttp/actions/workflows/update-pre-commit.yml). pre-commit auto update prs are actually created by pre-commit-ci app. This workflow is not needed anyway.

@Cycloctane Cycloctane requested a review from webknjaz as a code owner October 19, 2025 23:05
@Cycloctane Cycloctane requested a review from asvetlov as a code owner October 19, 2025 23:09
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 19, 2025
@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (e260b15) to head (54973a7).
⚠️ Report is 114 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #11689    +/-   ##
========================================
  Coverage   98.74%   98.74%            
========================================
  Files         127      127            
  Lines       43448    43549   +101     
  Branches     2326     2327     +1     
========================================
+ Hits        42903    43003   +100     
- Misses        389      390     +1     
  Partials      156      156            
Flag Coverage Δ
CI-GHA 98.63% <ø> (+<0.01%) ⬆️
OS-Linux 98.36% <ø> (+<0.01%) ⬆️
OS-Windows 96.69% <ø> (-0.01%) ⬇️
OS-macOS 97.58% <ø> (+<0.01%) ⬆️
Py-3.10.11 97.15% <ø> (+<0.01%) ⬆️
Py-3.10.18 ?
Py-3.10.19 97.65% <ø> (?)
Py-3.11.13 ?
Py-3.11.14 97.84% <ø> (?)
Py-3.11.9 97.35% <ø> (+<0.01%) ⬆️
Py-3.12.10 97.45% <ø> (+<0.01%) ⬆️
Py-3.12.11 ?
Py-3.12.12 97.95% <ø> (?)
Py-3.13.7 ?
Py-3.13.8 98.20% <ø> (?)
Py-3.14.0 98.15% <ø> (-0.01%) ⬇️
Py-3.14.0t 97.22% <ø> (+<0.01%) ⬆️
Py-pypy3.10.16-7.3.19 90.63% <ø> (-5.75%) ⬇️
VM-macos 97.58% <ø> (+<0.01%) ⬆️
VM-ubuntu 98.36% <ø> (+<0.01%) ⬆️
VM-windows 96.69% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 19, 2025

CodSpeed Performance Report

Merging #11689 will not alter performance

Comparing Cycloctane:remove-unused-ci (54973a7) with master (42fc48a)

Summary

✅ 59 untouched

@Cycloctane Cycloctane requested a review from webknjaz October 20, 2025 05:51
@Dreamsorcerer Dreamsorcerer added backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot labels Nov 21, 2025
@Dreamsorcerer Dreamsorcerer merged commit a091c73 into aio-libs:master Nov 21, 2025
42 of 43 checks passed
@patchback
Copy link
Contributor

patchback bot commented Nov 21, 2025

Backport to 3.13: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.13/a091c738132733766ef9d268fe2dd124c46c1975/pr-11689

Backported as #11769

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Contributor

patchback bot commented Nov 21, 2025

Backport to 3.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.14/a091c738132733766ef9d268fe2dd124c46c1975/pr-11689

Backported as #11770

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 21, 2025
Dreamsorcerer pushed a commit that referenced this pull request Nov 21, 2025
…i workflow (#11770)

**This is a backport of PR #11689 as merged into master
(a091c73).**

## What do these changes do?

update-pre-commit is broken after #5261 due to the incorrect
`github.repository_owner` condition. (See
<https://github.com/aio-libs/aiohttp/actions/workflows/update-pre-commit.yml>).
pre-commit auto update prs are actually created by pre-commit-ci app.
This workflow is not needed anyway.

Co-authored-by: Rui Xi <[email protected]>
Dreamsorcerer pushed a commit that referenced this pull request Nov 21, 2025
…i workflow (#11769)

**This is a backport of PR #11689 as merged into master
(a091c73).**

## What do these changes do?

update-pre-commit is broken after #5261 due to the incorrect
`github.repository_owner` condition. (See
<https://github.com/aio-libs/aiohttp/actions/workflows/update-pre-commit.yml>).
pre-commit auto update prs are actually created by pre-commit-ci app.
This workflow is not needed anyway.

Co-authored-by: Rui Xi <[email protected]>
@Cycloctane Cycloctane deleted the remove-unused-ci branch November 23, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants