Skip to content

Conversation

@patchback
Copy link
Contributor

@patchback patchback bot commented Oct 28, 2025

This is a backport of PR #11714 as merged into master (0d77d0d).

What do these changes do?

I optimized this one a bit too much assuming NETRC would always be set in #11634

fixes #11713

Are there changes in behavior for the user?

fix regression

Is it a substantial burden for the maintainers to support this?

no

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 0d77d0d)
@bdraco bdraco enabled auto-merge (squash) October 28, 2025 15:36
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 28, 2025

CodSpeed Performance Report

Merging #11728 will not alter performance

Comparing patchback/backports/3.14/0d77d0d64461bd9c98b30fb1f5ab246bb58f2b4e/pr-11714 (07a3476) with 3.14 (381334b)1

Summary

✅ 59 untouched

Footnotes

  1. No successful run was found on 3.14 (6d22d3a) during the generation of this report, so 381334b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.19%. Comparing base (381334b) to head (07a3476).
⚠️ Report is 11 commits behind head on 3.14.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.14   #11728   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files         128      128           
  Lines       43856    43880   +24     
  Branches     2386     2386           
=======================================
+ Hits        43063    43088   +25     
  Misses        611      611           
+ Partials      182      181    -1     
Flag Coverage Δ
CI-GHA 98.08% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.84% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.54% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.07% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.60% <100.00%> (+<0.01%) ⬆️
Py-3.10.18 97.10% <100.00%> (?)
Py-3.10.19 ?
Py-3.11.13 97.35% <100.00%> (?)
Py-3.11.14 ?
Py-3.11.9 96.85% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 96.94% <100.00%> (+<0.01%) ⬆️
Py-3.12.11 97.45% <100.00%> (?)
Py-3.12.12 ?
Py-3.13.7 97.44% <100.00%> (?)
Py-3.13.8 ?
Py-3.13.9 96.92% <100.00%> (?)
Py-3.14.0 97.65% <100.00%> (+<0.01%) ⬆️
Py-3.14.0t 96.74% <100.00%> (+<0.01%) ⬆️
Py-pypy3.10.16-7.3.19 89.90% <100.00%> (+0.42%) ⬆️
VM-macos 97.07% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.84% <100.00%> (+<0.01%) ⬆️
VM-windows 95.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 57ad7fa into 3.14 Oct 28, 2025
37 checks passed
@bdraco bdraco deleted the patchback/backports/3.14/0d77d0d64461bd9c98b30fb1f5ab246bb58f2b4e/pr-11714 branch October 28, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants