Skip to content

Drop RequestKey/ResponseKey warnings in v4 #11776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dreamsorcerer merged 9 commits into from
Dec 1, 2025
Merged

Drop RequestKey/ResponseKey warnings in v4 #11776

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8e50a8a
Drop RequestKey/ResponseKey warnings in v4
Dreamsorcerer Nov 28, 2025
a7b5eeb
Update web_response.py
Dreamsorcerer Nov 28, 2025
810d008
Update test_web_request.py
Dreamsorcerer Nov 28, 2025
cd41871
Update test_web_response.py
Dreamsorcerer Nov 28, 2025
ab35294
Create 11776.misc.rst
Dreamsorcerer Nov 28, 2025
b04ebb4
Update web_request.py
Dreamsorcerer Nov 28, 2025
6c417c5
Update web_response.py
Dreamsorcerer Nov 28, 2025
6ed0c76
Update test_web_response.py
Dreamsorcerer Nov 28, 2025
59776ea
Update test_web_request.py
Dreamsorcerer Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test_web_response.py
  • Loading branch information
@Dreamsorcerer
Dreamsorcerer authored Nov 28, 2025
commit cd41871b4f964b9ecab82231ff23ad6c10bae814
4 changes: 0 additions & 4 deletions tests/test_web_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ def test_stream_response_eq() -> None:
assert not resp1 == resp2


@pytest.mark.filterwarnings(r"ignore:.*web\.ResponseKey:UserWarning")
def test_stream_response_is_mutable_mapping() -> None:
resp = web.StreamResponse()
assert isinstance(resp, collections.abc.MutableMapping)
Expand All @@ -99,23 +98,20 @@ def test_stream_response_is_mutable_mapping() -> None:
assert "value" == resp["key"]


@pytest.mark.filterwarnings(r"ignore:.*web\.ResponseKey:UserWarning")
def test_stream_response_delitem() -> None:
resp = web.StreamResponse()
resp["key"] = "value"
del resp["key"]
assert "key" not in resp


@pytest.mark.filterwarnings(r"ignore:.*web\.ResponseKey:UserWarning")
def test_stream_response_len() -> None:
resp = web.StreamResponse()
assert len(resp) == 0
resp["key"] = "value"
assert len(resp) == 1


@pytest.mark.filterwarnings(r"ignore:.*web\.ResponseKey:UserWarning")
def test_response_iter() -> None:
resp = web.StreamResponse()
resp["key"] = "value"
Expand Down