Static file handler for aiohttp.web

[mind1m]

No description provided.

[telendt]

I'd rather prefer to run all file IO operations in ThreadPoolExecutor, so that they don't block the loop. There are also some features missing, like Content-Range/Last-Modified/ETag support.

[fafhrd91]

i'd rather have static handler as helper class. is it possible to do something like this?

   app.router.add_route('/static/*', StaticFilesHandler(filesystem_path))

[mind1m]

I think, generally, ThreadPoolExecutor makes sense, so does Content-Range/Last-Modified/ETag. However, as far as I understand, this meant to be just the development solution; for production nginx or similar should be used for static handling. @fafhrd91 @asvetlov what do you think?

@fafhrd91
It is possible, but it would rather look like this:

app.router.add_route('GET', r'/static/(?P<filename>.*)', StaticFilesHandler(filesystem_path))

Here method and regex seem to be unnecessary, but this is the only way it could be done without modifying add_route

[fafhrd91]

ok, add_route solution looks ugly.
in general i am +0 on that.

asyncio does not support async operations on files, so i don't think serving static files is good idea for production.

[asvetlov]

I think static file handling is useful feature for development-only.

Merged.
Support for Content-Range and caching is useful in general but can be done in separate pull request (see #165).

[ludovic-gasc]

+1 for this PR, it's necessary during development process.

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.