Skip to content

Conversation

@zacholade
Copy link
Contributor

@zacholade zacholade commented Mar 25, 2019

First of all; thanks for the amazing repo. Just a very small change from me today. It's been bothering me haha.

What do these changes do?

Fix a typo in the commented code.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Mar 25, 2019

Codecov Report

Merging #3666 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3666   +/-   ##
======================================
  Coverage    97.9%   97.9%           
======================================
  Files          43      43           
  Lines        8556    8556           
  Branches     1376    1376           
======================================
  Hits         8377    8377           
  Misses         74      74           
  Partials      105     105
Impacted Files Coverage Δ
aiohttp/web_runner.py 97.92% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7345ffb...ca647ff. Read the comment docs.

@webknjaz webknjaz merged commit 2bf371e into aio-libs:master Mar 27, 2019
@webknjaz
Copy link
Member

Thanks @SirGhostal!

@lock lock bot added the outdated label Mar 27, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants