Skip to content

Use more precise headers type #8776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dreamsorcerer merged 7 commits into from
Aug 20, 2024
Merged

Use more precise headers type #8776

Dreamsorcerer merged 7 commits into from
Aug 20, 2024

Conversation

@Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Aug 19, 2024

Fixes #8768.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 19, 2024
@codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.14%. Comparing base (d50f275) to head (c610f5f).
Report is 1031 commits behind head on master.

Files with missing lines Patch % Lines
tests/test_client_exceptions.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8776   +/-   ##
=======================================
  Coverage   98.13%   98.14%           
=======================================
  Files         107      107           
  Lines       34067    34068    +1     
  Branches     4030     4030           
=======================================
+ Hits        33433    33436    +3     
+ Misses        457      456    -1     
+ Partials      177      176    -1
Flag Coverage Δ
CI-GHA 98.04% <66.66%> (+<0.01%) ⬆️
OS-Linux 97.69% <66.66%> (+<0.01%) ⬆️
OS-Windows 96.06% <66.66%> (+<0.01%) ⬆️
OS-macOS 97.35% <66.66%> (+<0.01%) ⬆️
Py-3.10.11 97.43% <66.66%> (+<0.01%) ⬆️
Py-3.10.14 97.39% <66.66%> (+<0.01%) ⬆️
Py-3.11.9 97.62% <66.66%> (+<0.01%) ⬆️
Py-3.12.4 97.73% <66.66%> (+0.11%) ⬆️
Py-3.12.5 ?
Py-3.8.10 95.70% <66.66%> (+<0.01%) ⬆️
Py-3.8.18 97.20% <66.66%> (+<0.01%) ⬆️
Py-3.9.13 97.34% <66.66%> (+<0.01%) ⬆️
Py-3.9.19 97.29% <66.66%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.90% <66.66%> (+<0.01%) ⬆️
VM-macos 97.35% <66.66%> (+<0.01%) ⬆️
VM-ubuntu 97.69% <66.66%> (+<0.01%) ⬆️
VM-windows 96.06% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 11171b8 into master Aug 20, 2024
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-4 branch August 20, 2024 00:53
@patchback
Copy link
Contributor

patchback bot commented Aug 20, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/11171b8d4dc269cc05c59befc105b6744f2640e3/pr-8776

Backported as #8777

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 20, 2024
@Dreamsorcerer @patchback
Use more precise headers type (#8776)
3c6e723 
(cherry picked from commit 11171b8)
@patchback patchback bot mentioned this pull request Aug 20, 2024
Merged
@patchback
Copy link
Contributor

patchback bot commented Aug 20, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/11171b8d4dc269cc05c59befc105b6744f2640e3/pr-8776

Backported as #8778

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 20, 2024
@Dreamsorcerer @patchback
Use more precise headers type (#8776)
e04993e 
(cherry picked from commit 11171b8)
@patchback patchback bot mentioned this pull request Aug 20, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Aug 20, 2024
@patchback @Dreamsorcerer
[PR #8776/11171b8d backport][3.11] Use more precise headers type (#8778)
5ee29e7 
**This is a backport of PR #8776 as merged into master
(11171b8).**

---------

Co-authored-by: Sam Bull <[email protected]>
Dreamsorcerer added a commit that referenced this pull request Aug 20, 2024
@patchback @Dreamsorcerer
[PR #8776/11171b8d backport][3.10] Use more precise headers type (#8777)
014db7e 
**This is a backport of PR #8776 as merged into master
(11171b8).**

---------

Co-authored-by: Sam Bull <[email protected]>
@booniepepper booniepepper mentioned this pull request Sep 3, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[typing] mypy errors when trying to extract headers when type is LooseHeaders

2 participants

@Dreamsorcerer