Skip to content

Drop Python 3.8 #8797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dreamsorcerer merged 8 commits into from
Aug 20, 2024
Merged

Drop Python 3.8 #8797

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c16981f
Drop Python 3.8
Dreamsorcerer Aug 20, 2024
feb0462
Update setup.py
Dreamsorcerer Aug 20, 2024
16f10c3
Update test_resolver.py
Dreamsorcerer Aug 20, 2024
bea7844
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 20, 2024
3f1e621
Create 8797.breaking.rst
Dreamsorcerer Aug 20, 2024
2b04c3e
Update resolver.py
Dreamsorcerer Aug 20, 2024
57d5a6d
Update web_fileresponse.py
Dreamsorcerer Aug 20, 2024
5b6d15d
Merge branch 'master' into drop-3.8
Dreamsorcerer Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test_resolver.py
  • Loading branch information
@Dreamsorcerer
Dreamsorcerer authored Aug 20, 2024
commit 16f10c33171b46b2c4430f8a0f95aaf81b41a845
14 changes: 1 addition & 13 deletions tests/test_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,7 @@

import pytest

from aiohttp.resolver import (
_NUMERIC_SOCKET_FLAGS,
_SUPPORTS_SCOPE_ID,
AsyncResolver,
DefaultResolver,
ThreadedResolver,
)
from aiohttp.resolver import _NUMERIC_SOCKET_FLAGS, AsyncResolver, DefaultResolver, ThreadedResolver

try:
import aiodns
Expand Down Expand Up @@ -138,9 +132,6 @@ async def test_async_resolver_positive_ipv4_lookup(loop: Any) -> None:


@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
@pytest.mark.skipif(
not _SUPPORTS_SCOPE_ID, reason="python version does not support scope id"
)
async def test_async_resolver_positive_link_local_ipv6_lookup(loop: Any) -> None:
with patch("aiodns.DNSResolver") as mock:
mock().getaddrinfo.return_value = fake_aiodns_getaddrinfo_ipv6_result(
Expand Down Expand Up @@ -203,9 +194,6 @@ async def test_threaded_resolver_positive_lookup() -> None:
ipaddress.ip_address(real[0]["host"])


@pytest.mark.skipif(
not _SUPPORTS_SCOPE_ID, reason="python version does not support scope id"
)
async def test_threaded_resolver_positive_ipv6_link_local_lookup() -> None:
loop = Mock()
loop.getaddrinfo = fake_ipv6_addrinfo(["fe80::1"])
Expand Down