Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Aug 23, 2024

What do these changes do?

Most of the time there are no auto_headers

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

before
before

after
after

Most of the time there are no auto_headers
@bdraco bdraco changed the title Improve performance of handling auto_headers Improve performance of handling skip_auto_headers Aug 23, 2024
@codecov
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (e058cbd) to head (5939a71).
Report is 1054 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8847   +/-   ##
=======================================
  Coverage   98.23%   98.24%           
=======================================
  Files         107      107           
  Lines       34123    34124    +1     
  Branches     4050     4050           
=======================================
+ Hits        33522    33525    +3     
+ Misses        424      423    -1     
+ Partials      177      176    -1     
Flag Coverage Δ
CI-GHA 98.13% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.79% <100.00%> (-0.01%) ⬇️
OS-Windows 96.19% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.47% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.56% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.49% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.73% <100.00%> (+<0.01%) ⬆️
Py-3.12.4 95.99% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.52% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.45% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 97.39% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.00% <100.00%> (+<0.01%) ⬆️
VM-macos 97.47% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.79% <100.00%> (-0.01%) ⬇️
VM-windows 96.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review August 24, 2024 15:40
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 26, 2024
@bdraco bdraco enabled auto-merge (squash) August 26, 2024 19:24
@bdraco bdraco merged commit 6d97427 into master Aug 26, 2024
@bdraco bdraco deleted the auto_headers branch August 26, 2024 19:28
@patchback
Copy link
Contributor

patchback bot commented Aug 26, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/6d9742743da6c8e07d67bc365d98110eb208cd30/pr-8847

Backported as #8904

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Contributor

patchback bot commented Aug 26, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/6d9742743da6c8e07d67bc365d98110eb208cd30/pr-8847

Backported as #8905

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants