Small cleanups to the websocket frame sender #8933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add some comments about what is going on in _send_frame since much of the logic is not obvious - Avoid fetch the len() in a few places where its a fixed value and already known
- Add some comments about what is going on in _send_frame since much of the logic is not obvious - Avoid fetch the len() in a few places where its a fixed value and already known
- Add some comments about what is going on in _send_frame since much of the logic is not obvious - Avoid fetch the len() in a few places where its a fixed value and already known
bdraco
added
backport-3.10
bot:chronographer:skip
- Add some comments about what is going on in _send_frame since much of the logic is not obvious - Avoid fetch the len() in a few places where its a fixed value and already known
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #8933 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 107 107
Lines 34136 34139 +3
Branches 4048 4047 -1
=======================================
+ Hits 33541 33544 +3
Misses 421 421
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8978 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 1, 2024
(cherry picked from commit 8f3b1f4)
Contributor
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #8979 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 1, 2024
(cherry picked from commit 8f3b1f4)
bdraco
added a commit
that referenced
this pull request
Sep 1, 2024
…ame sender (#8978) Co-authored-by: J. Nick Koston <[email protected]>
bdraco
added a commit
that referenced
this pull request
Sep 1, 2024
…ame sender (#8979) Co-authored-by: J. Nick Koston <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no