[PR #8948/cc6d7632 backport][3.10] Make n argument clearer #8949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit cc6d763)
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.10 #8949 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 108 108
Lines 34329 34329
Branches 4077 4077
=======================================
Hits 33552 33552
Misses 581 581
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
approved these changes
Aug 30, 2024
bdraco
deleted the
patchback/backports/3.10/cc6d76321151f6e5d2210815f8fa60cd8e7c76f1/pr-8948
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #8948 as merged into master (cc6d763).
Judging by the closed issues, we seem to have a lot of users who don't understand what "up to" means. This adds more words to hopefully make it clearer.