Skip to content

Move ContentDisposition in reference docs #8987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dreamsorcerer merged 1 commit into from
Sep 2, 2024
Merged

Move ContentDisposition in reference docs #8987

Dreamsorcerer merged 1 commit into from
Sep 2, 2024
+20 −19

Conversation

@Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Sep 2, 2024 •
edited
Loading

Fixes #7450.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.10 labels Sep 2, 2024
@codecov
Copy link

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (64a3d30) to head (4d30fee).
Report is 3141 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8987      +/-   ##
==========================================
+ Coverage   97.74%   98.28%   +0.54%     
==========================================
  Files         108      107       -1     
  Lines       34369    34317      -52     
  Branches     4082     4064      -18     
==========================================
+ Hits        33593    33729     +136     
+ Misses        580      415     -165     
+ Partials      196      173      -23
Flag Coverage Δ
CI-GHA 98.18% <ø> (+0.54%) ⬆️
OS-Linux 97.84% <ø> (+0.52%) ⬆️
OS-Windows 96.25% <ø> (+1.37%) ⬆️
OS-macOS 97.52% <ø> (+0.50%) ⬆️
Py-3.10.11 97.61% <ø> (+0.52%) ⬆️
Py-3.10.14 97.54% <ø> (+0.52%) ⬆️
Py-3.11.9 97.77% <ø> (+0.52%) ⬆️
Py-3.12.5 97.89% <ø> (+0.54%) ⬆️
Py-3.8.10 ?
Py-3.8.18 ?
Py-3.9.13 97.50% <ø> (+0.51%) ⬆️
Py-3.9.19 97.44% <ø> (+0.51%) ⬆️
Py-pypy7.3.16 97.05% <ø> (+0.52%) ⬆️
VM-macos 97.52% <ø> (+0.50%) ⬆️
VM-ubuntu 97.84% <ø> (+0.52%) ⬆️
VM-windows 96.25% <ø> (+1.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 5c3d50f into master Sep 2, 2024
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-5 branch September 2, 2024 14:45
@patchback
Copy link
Contributor

patchback bot commented Sep 2, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/5c3d50f9006a0e86927cfc3f092ec2a30b490871/pr-8987

Backported as #8988

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 2, 2024
@Dreamsorcerer @patchback
Move ContentDisposition in reference docs (#8987)
46e6c50 
(cherry picked from commit 5c3d50f)
@patchback patchback bot mentioned this pull request Sep 2, 2024
Merged
@patchback
Copy link
Contributor

patchback bot commented Sep 2, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/5c3d50f9006a0e86927cfc3f092ec2a30b490871/pr-8987

Backported as #8989

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 2, 2024
@Dreamsorcerer @patchback
Move ContentDisposition in reference docs (#8987)
9f72300 
(cherry picked from commit 5c3d50f)
@patchback patchback bot mentioned this pull request Sep 2, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Sep 2, 2024
@patchback @Dreamsorcerer
[PR #8987/5c3d50f9 backport][3.11] Move ContentDisposition in referen…
ed5576d 
…ce docs (#8989)

**This is a backport of PR #8987 as merged into master
(5c3d50f).**

Co-authored-by: Sam Bull <[email protected]>
Dreamsorcerer added a commit that referenced this pull request Sep 2, 2024
@patchback @Dreamsorcerer
[PR #8987/5c3d50f9 backport][3.10] Move ContentDisposition in referen…
7c3ff64 
…ce docs (#8988)

**This is a backport of PR #8987 as merged into master
(5c3d50f).**

Co-authored-by: Sam Bull <[email protected]>
@booniepepper booniepepper mentioned this pull request Sep 3, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ContentDisposition is not an exception

2 participants

@Dreamsorcerer