Skip to content

Fix changing scheme/host in Response.clone() for absolute URLs #8990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dreamsorcerer merged 3 commits into from
Sep 2, 2024
Merged

Fix changing scheme/host in Response.clone() for absolute URLs #8990

Dreamsorcerer merged 3 commits into from
Sep 2, 2024

Conversation

@Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Sep 2, 2024

Fixes #7481.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 2, 2024
Dreamsorcerer
Dreamsorcerer commented Sep 2, 2024
View reviewed changes
@codecov
Copy link

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (5c3d50f) to head (196c5d2).
Report is 1060 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8990   +/-   ##
=======================================
  Coverage   98.28%   98.29%           
=======================================
  Files         107      107           
  Lines       34317    34338   +21     
  Branches     4064     4066    +2     
=======================================
+ Hits        33729    33752   +23     
+ Misses        415      414    -1     
+ Partials      173      172    -1
Flag Coverage Δ
CI-GHA 98.18% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.85% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.26% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.52% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.62% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.55% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.78% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.90% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.51% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 97.45% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.06% <100.00%> (+<0.01%) ⬆️
VM-macos 97.52% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.85% <100.00%> (+<0.01%) ⬆️
VM-windows 96.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 731ba4d into master Sep 2, 2024
@Dreamsorcerer Dreamsorcerer deleted the fix-clone-absolute branch September 2, 2024 21:47
@patchback
Copy link
Contributor

patchback bot commented Sep 2, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/731ba4dd399c26fd470dde5ea50e011e058b798a/pr-8990

Backported as #8996

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 2, 2024
@Dreamsorcerer @patchback
Fix changing scheme/host in Response.clone() for absolute URLs (#8990)
5b71843 
(cherry picked from commit 731ba4d)
@patchback patchback bot mentioned this pull request Sep 2, 2024
Merged
@patchback
Copy link
Contributor

patchback bot commented Sep 2, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/731ba4dd399c26fd470dde5ea50e011e058b798a/pr-8990

Backported as #8997

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 2, 2024
@Dreamsorcerer @patchback
Fix changing scheme/host in Response.clone() for absolute URLs (#8990)
8fec5e9 
(cherry picked from commit 731ba4d)
@patchback patchback bot mentioned this pull request Sep 2, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Sep 2, 2024
@patchback @Dreamsorcerer
[PR #8990/731ba4dd backport][3.11] Fix changing scheme/host in Respon…
fa628a2 
…se.clone() for absolute URLs (#8997)

**This is a backport of PR #8990 as merged into master
(731ba4d).**

Co-authored-by: Sam Bull <[email protected]>
Dreamsorcerer added a commit that referenced this pull request Sep 2, 2024
@patchback @Dreamsorcerer
[PR #8990/731ba4dd backport][3.10] Fix changing scheme/host in Respon…
af8900d 
…se.clone() for absolute URLs (#8996)

**This is a backport of PR #8990 as merged into master
(731ba4d).**

Co-authored-by: Sam Bull <[email protected]>
@booniepepper booniepepper mentioned this pull request Sep 3, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdraco bdraco bdraco approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

web.Request.clone bug

3 participants

@Dreamsorcerer @bdraco