Skip to content

Conversation

maciej-gurban
Copy link

Changed the way strings are concatenated, by making the concatenation at the beginning of a line, which seems like a bit cleaner solution.

@drkibitz
Copy link

👎 this is like the comma-first practice. It may have purpose, but too many people do and will take the previous as the standard.

@nmussy
Copy link
Contributor

nmussy commented Dec 10, 2013

This kind of goes against the leading commas section, in my opinion. It makes the text harder to read.

@nmussy
Copy link
Contributor

nmussy commented Dec 10, 2013

@drkibitz five hour old pull request, 10 second appart answers.

@drkibitz
Copy link

@nmussy Just having my morning ☕ and reading Github notifications 😎

@nmussy
Copy link
Contributor

nmussy commented Dec 10, 2013

@drkibitz Catching up on the day's notification here, being GMT + 1 and all. That probably makes it funnier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants