-
Notifications
You must be signed in to change notification settings - Fork 26.8k
small code example and typo fixes #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Careful, if you return options
, then this function constructor won't work as expected! Although maybe something like this is more useful:
this.options = options || {};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…gested by spikebrehm #36 (comment)
Thanks for the PR @thisconnect! Looks like some really nice cleanup. Before I merge this in, why double quotes for the markup? |
Personally I always use single quotes for JavaScript and double quotes for markup and CSS. This in cases where you have to write markup or style in JavaScript
or the other way around
But the it doesn't matter for html in markdown. Please just git cherry-pick the commits you like. See also http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml#HTML_quotation_marks but then the google html/css styleguide also proposes using single quotes for CSS which I don't prefer, since they are clearly wrong :P . |
@h4rry do you want me to try to revert that double quotes commit, so you can just pull? |
@thisconnect yes please! that'd be much appreciated 🍻 |
Reverted a2fd260 but got a little merge conflict with Compatability -> Compatibility. Should be good now. |
Looks great! Thanks! |
small code example and typo fixes
please cherry-pick whatever you like