Skip to content

assign variables: give a reason for the assignment #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2016
Merged

assign variables: give a reason for the assignment #656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 14 additions & 23 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,45 +1102,36 @@ Other Style Guides
> Why? `let` and `const` are block scoped and not function scoped.

```javascript
// good
function () {
test();
console.log('doing stuff..');

//..other stuff..

// bad - unnecessary function call
function checkName(hasName) {
const name = getName();

if (name === 'test') {
if (hasName === 'test') {
return false;
}

return name;
}

// bad - unnecessary function call
function (hasName) {
const name = getName();

if (!hasName) {
if (name === 'test') {
this.setName('');
return false;
}

this.setFirstName(name);

return true;
return name;
}

// good
function (hasName) {
if (!hasName) {
function checkName(hasName) {
if (hasName === 'test') {
return false;
}

const name = getName();
this.setFirstName(name);

return true;
if (name === 'test') {
this.setName('');
return false;
}

return name;
}
```

Expand Down