Make notifyXml return a Buffer object#51
Merged
shime merged 1 commit intoairbrake:masterfrom Feb 12, 2016
Merged
Conversation
If (for example) request.body contains non-ascii characters, this caused the http request to not send the correct `Content-Length` header, which in turn causes errbit to not read the entire document. I changed `Airbrake.prototype.notifyXml` so that it returns a `Buffer` object, which will report a proper length when asked for it in `Airbarke.prototype.notify`.
|
Status on this? |
|
Does this break something, or why is it not merged? It seems to fix the incompatibility with errbit... |
Contributor
Author
|
The CI build failed, but that was unrelated to my changes. And yes, this does fix the errbit incompatibility. Or at least it did 10 months ago. |
shime
pushed a commit
that referenced
this pull request
Feb 12, 2016
Make notifyXml return a Buffer object
|
Hehe - long live open source @Frost ;) |
Contributor
Author
|
@brodin Long lived, at least ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If (for example) request.body contains non-ascii characters, this caused the http request to not send the correct
Content-Lengthheader, which in turn causes errbit to not read the entire document.I changed
Airbrake.prototype.notifyXmlso that it returns aBufferobject, which will report a proper length when asked for it inAirbarke.prototype.notify.