Skip to content

Stop serializing all environment variables #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shime merged 10 commits into from
Feb 23, 2016
Merged

Stop serializing all environment variables #84

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e35b9ba
stop serializing all environment variables
shime Feb 15, 2016
63abc66
make env vars customizable
shime Feb 17, 2016
55bf655
update features in the readme
shime Feb 17, 2016
2f20aa3
remove environment variable blacklisting
shime Feb 18, 2016
bb0911c
document whitelisting of env vars
shime Feb 18, 2016
e06b142
support both whitelisting and blacklisting of env vars
shime Feb 19, 2016
22396dc
update readme
shime Feb 19, 2016
f516794
add "[FILTERED]" label to filtered keys
shime Feb 23, 2016
d8e1c3c
fix whitespace
shime Feb 23, 2016
602dbe6
update changelog
shime Feb 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix whitespace
  • Loading branch information
@shime
shime committed Feb 23, 2016
commit d8e1c3c3dea5401bcc69d7e687a312e415cdbbfc
8 changes: 4 additions & 4 deletions lib/airbrake.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,17 +318,17 @@ Airbrake.prototype.cgiDataVars = function(err) {
var cgiData = {};
var self = this;
Copy link
Copy Markdown
Contributor

@kyrylo kyrylo Feb 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forEach on line 330 should support second argument - thisArg, so you don't have to store this.


if (this.whiteListKeys.length > 0){
if (this.whiteListKeys.length > 0) {
Object.keys(process.env).forEach(function(key) {
if (self.whiteListKeys.indexOf(key) > -1){
if (self.whiteListKeys.indexOf(key) > -1) {
cgiData[key] = process.env[key];
} else {
cgiData[key] = "[FILTERED]";
}
})
} else if (this.blackListKeys.length > 0){
} else if (this.blackListKeys.length > 0) {
Object.keys(process.env).forEach(function(key) {
if (self.blackListKeys.indexOf(key) > -1){
if (self.blackListKeys.indexOf(key) > -1 ) {
cgiData[key] = "[FILTERED]";
} else {
cgiData[key] = process.env[key];
Expand Down