automatically parse repo and rev from local repo#88
Merged
Conversation
shime
force-pushed
the
feature/auto-rev-and-repo
branch
from
b55339b to
e9e087a
Compare
shime
force-pushed
the
feature/auto-rev-and-repo
branch
from
e9e087a to
241826a
Compare
| var hashish = require('hashish'); | ||
| var querystring = require('querystring'); | ||
| var stringify = require('json-stringify-safe'); | ||
| var execSync = require('sync-exec'); |
Contributor
There was a problem hiding this comment.
@shime Why add a dependency when you can use child_process.execSync
Contributor
Author
There was a problem hiding this comment.
@jadengore we have to support older node versions, where child_process doesn't have execSync defined.
Contributor
There was a problem hiding this comment.
@shime Maybe there needs to be a support section to the README so people know what versions node-airbrake supports.
Contributor
Author
There was a problem hiding this comment.
@jadengore yeah, that's a good idea, I'll add it to the readme
Contributor
|
LGTM |
Contributor
|
What's the status here? |
Contributor
Author
|
LGTM. You didn't need to wait for my review :) |
Contributor
|
👏 👏 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repo and revision can be parsed automatically when deploying.