Remove run-hook, it is run automatically.
#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi.
When using `define-derived-mode` one doesn't need (and shouldn't) use `run-hook` because the macro adds the form `run-mode-hook` itself when expanded (use macroexpand to check!).
This results in the hook being called twice, see
```elisp
(defun my-nginx-mode-init ()
(message "Hello"))
(add-hook 'nginx-mode-hook 'my-nginx-mode-init)
```
In messages I have
Hello [2 times]
Simply removing the form and using the one provided by the macro is enough to fix this.
ajc
approved these changes
May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
When using
define-derived-modeone doesn't need (and shouldn't) userun-hookbecause the macro adds the formrun-mode-hookitself when expanded (use macroexpand to check!).This results in the hook being called twice, see
In messages I have
Simply removing the form and using the one provided by the macro is enough to fix this.