-
Notifications
You must be signed in to change notification settings - Fork 70
feat: replace static event name with dynamic based on event id #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
13d20ae
8c44723
db6c249
a9b16cd
db918eb
5b3b00d
35f3254
5608829
34deb18
981fed4
7bff9fe
1ba8a8e
30430b8
f3ccc93
c45effe
74af1f5
d11f441
0d122ac
7bdd8e3
a23579b
4086ca4
369e109
6cd31b3
656b19a
187bd0e
140f628
6377a8a
0b38f7a
5d6e603
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ telemetry: | |
| - qname: test.net0 | ||
| id: guard.jwt.authorization.failed | ||
| name: GUARD_JWT_AUTHORIZATION_FAILED | ||
| message: user | ||
| message: No active session found for token identity (user). | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This message seems to imply we are looking for matching state in zilla and couldn't find it. However, I think this event is logged when an attempt to authorize the user (by validating the token) fails, with no implication of state expected to be found at zilla. Let's reword to capture the underlying behavior without implying expectation to find server-side state, agree?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated, please review the new wording with the added |
||
| guards: | ||
| jwt0: | ||
| type: jwt | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.