Skip to content

Ensure new mqtt subscriptions are not empty #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfallows merged 1 commit into from
May 21, 2024
Merged

Ensure new mqtt subscriptions are not empty #1040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Ensure new mqtt subscriptions are not empty
  • Loading branch information
@jfallows
jfallows committed May 21, 2024
commit 4e21f765947694f16a80a7653c38dd4249f6cecf
3 changes: 2 additions & 1 deletion ...c/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5369,7 +5369,8 @@ private void onSessionData(
List<Subscription> newSubscriptions = newState.stream()
.filter(s -> !currentSubscriptions.contains(s))
.collect(Collectors.toList());
if (subscribePacketIds.containsKey(newSubscriptions.get(0).id))
if (!newSubscriptions.isEmpty() &&
subscribePacketIds.containsKey(newSubscriptions.get(0).id))
{
int packetId = subscribePacketIds.get(newSubscriptions.get(0).id);
newSubscriptions.forEach(sub -> subscribePacketIds.remove(sub.id));
Expand Down