Skip to content

Added declarative helmfile #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfallows merged 5 commits into from
May 31, 2024
Merged

Added declarative helmfile #1054

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
333327f
Create helmfile.yaml
ttimot24 May 25, 2024
353a967
Move helmfile
ttimot24 May 25, 2024
95f54b6
Fix helmfile.yaml
ttimot24 May 25, 2024
54bb83d
Merge branch 'aklivity:develop' into develop
ttimot24 May 30, 2024
5519607
Use version range instead harcoded version
ttimot24 May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix helmfile.yaml
  • Loading branch information
@ttimot24
ttimot24 authored May 25, 2024
commit 95f54b6b182301b6d50d6a685b238283b1324858
13 changes: 10 additions & 3 deletions cloud/helm-chart/src/main/helm/zilla/helmfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
helmDefaults:
wait: true
createNamespace: true

releases:
- name: zilla
namespace: default
namespace: zilla
chart: oci://ghcr.io/aklivity/charts/zilla
version: 0.9.81

@vordimous vordimous May 28, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will need a way to dynamically set this field right @attilakreiner?

@attilakreiner attilakreiner May 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion is that we go with ^0.9.0 so it is consistent with our examples e.g. setup.sh#L6

values:
- zilla.yaml: '{{ readFile "zilla.yaml" }}'
set:
# single value loaded from a local file, translates to --set-file zilla\\.yaml=zilla.yaml
# as described in: https://artifacthub.io/packages/helm/zilla/zilla#configuration
- name: "zilla\\.yaml"
file: zilla.yaml