Skip to content

Add sse payload validation #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfallows merged 5 commits into from
Jun 17, 2024
Merged

Add sse payload validation #1092

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72b891e
Add sse payload validation
bmaidics Jun 12, 2024
ec2b8cf
Fix SseOptionsConfig
bmaidics Jun 12, 2024
75f78a0
Add nullcheck for payload
bmaidics Jun 12, 2024
98c0cdd
Remove todo
bmaidics Jun 13, 2024
bb5d2e3
Review fixes
bmaidics Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add nullcheck for payload
  • Loading branch information
@bmaidics
bmaidics committed Jun 13, 2024
commit 75f78a078a190207135e538b911d414c697b9532
2 changes: 1 addition & 1 deletion ...src/main/java/io/aklivity/zilla/runtime/binding/sse/internal/stream/SseServerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,7 +1049,7 @@ private void onAppData(
timestamp = supplyTimestamp.applyAsLong(sseDataEx);
}

if (contentType == null || validContent(traceId, contentType, payload))
if (contentType == null || payload != null && validContent(traceId, contentType, payload))
{
doEncodeEvent(traceId, authorization, budgetId, reserved, flags, payload, id, type, timestamp);
}
Expand Down