Skip to content

Verify public-private tls key pair #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfallows merged 5 commits into from
Jun 28, 2024
Merged

Verify public-private tls key pair #1108

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b552a09
Verify public-private tls key pair
attilakreiner Jun 27, 2024
310fa87
fix mv keypair key
attilakreiner Jun 28, 2024
c2a8ed1
fix TlsBindingConfig init
attilakreiner Jun 28, 2024
5dba8c0
fix verifier
attilakreiner Jun 28, 2024
585156a
fix ref TlsKeyPairVerifier verify
attilakreiner Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix TlsBindingConfig init
  • Loading branch information
@attilakreiner
attilakreiner committed Jun 28, 2024
commit c2a8ed10db7126c4c0ef3e3c55ec72306c87cc76
7 changes: 4 additions & 3 deletions ...src/main/java/io/aklivity/zilla/runtime/binding/tls/internal/config/TlsBindingConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,15 @@ public TlsBindingConfig(

public void init(
TlsConfiguration config,
TlsEventContext events,
VaultHandler vault,
SecureRandom random,
TlsEventContext event)
SecureRandom random)
{
this.verifier = new TlsKeyPairVerifier(event);
this.verifier = new TlsKeyPairVerifier(events);
char[] keysPass = "generated".toCharArray();
KeyStore keys = newKeys(config, vault, keysPass, options.keys, options.signers);
KeyStore trust = newTrust(config, vault, options.trust, options.trustcacerts && kind == KindConfig.CLIENT);

try
{
KeyManager[] keyManagers = null;
Expand Down
2 changes: 1 addition & 1 deletion ...src/main/java/io/aklivity/zilla/runtime/binding/tls/internal/stream/TlsClientFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ public void attach(

VaultHandler vault = supplyVault.apply(tlsBinding.vaultId);

tlsBinding.init(config, vault, random, event);
tlsBinding.init(config, event, vault, random);

bindings.put(binding.id, tlsBinding);
}
Expand Down
2 changes: 1 addition & 1 deletion ...src/main/java/io/aklivity/zilla/runtime/binding/tls/internal/stream/TlsServerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ public void attach(

VaultHandler vault = supplyVault.apply(tlsBinding.vaultId);

tlsBinding.init(config, vault, random, event);
tlsBinding.init(config, event, vault, random);

bindings.put(binding.id, tlsBinding);
}
Expand Down