Skip to content

Flush the insert to have immediate effect #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfallows merged 2 commits into from
Jan 10, 2025
Merged

Flush the insert to have immediate effect #1365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fc8058
Flush the insert to have immediate effect
akrambek Jan 9, 2025
364bc5f
Fix typo
akrambek Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .../io/aklivity/zilla/specs/binding/risingwave/streams/effective/create.zfunction/client.rpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,30 @@ read advised zilla:flush ${pgsql:flushEx()
.build()
.build()}

write zilla:data.ext ${pgsql:dataEx()
.typeId(zilla:id("pgsql"))
.query()
.build()
.build()}
write "FLUSH;"
[0x00]

write flush

read advised zilla:flush ${pgsql:flushEx()
.typeId(zilla:id("pgsql"))
.completion()
.tag("FLUSH")
.build()
.build()}

read advised zilla:flush ${pgsql:flushEx()
.typeId(zilla:id("pgsql"))
.ready()
.status("IDLE")
.build()
.build()}

connect "zilla://streams/app1"
option zilla:window 8192
option zilla:transmission "duplex"
Expand Down
23 changes: 23 additions & 0 deletions .../io/aklivity/zilla/specs/binding/risingwave/streams/effective/create.zfunction/server.rpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,29 @@ write advise zilla:flush ${pgsql:flushEx()
.build()
.build()}

read zilla:data.ext ${pgsql:dataEx()
.typeId(zilla:id("pgsql"))
.query()
.build()
.build()}
read "FLUSH;"
[0x00]

write advise zilla:flush ${pgsql:flushEx()
.typeId(zilla:id("pgsql"))
.completion()
.tag("FLUSH")
.build()
.build()}

write advise zilla:flush ${pgsql:flushEx()
.typeId(zilla:id("pgsql"))
.ready()
.status("IDLE")
.build()
.build()}


accepted


Expand Down
41 changes: 40 additions & 1 deletion ...ivity/zilla/runtime/binding/risingwave/internal/macro/RisingwaveCreateZfunctionMacro.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import io.aklivity.zilla.runtime.binding.risingwave.internal.stream.RisingwaveCompletionCommand;
import io.aklivity.zilla.runtime.binding.risingwave.internal.types.stream.PgsqlFlushExFW;

public class RisingwaveCreateZfunctionMacro
public class RisingwaveCreateZfunctionMacro extends RisingwaveMacroBase
{
private static final String ZFUNCTION_NAME = "zfunctions";

Expand All @@ -35,6 +35,8 @@ public RisingwaveCreateZfunctionMacro(
CreateZfunction command,
RisingwaveMacroHandler handler)
{
super(sql, handler);

this.systemSchema = systemSchema;
this.user = user;
this.sql = sql;
Expand Down Expand Up @@ -67,6 +69,43 @@ public void onStarted(
handler.doExecuteSystemClient(traceId, authorization, sqlQuery);
}

@Override
public RisingwaveMacroState onReady(
long traceId,
long authorization,
PgsqlFlushExFW flushEx)
{
FlushState state = new FlushState();
state.onStarted(traceId, authorization);

return state;
}

@Override
public RisingwaveMacroState onError(
long traceId,
long authorization,
PgsqlFlushExFW flushEx)
{
handler.doFlushProxy(traceId, authorization, flushEx);

return errorState();
}
}

private final class FlushState implements RisingwaveMacroState
{
private final String sqlFormat = """
FLUSH;\u0000""";

@Override
public void onStarted(
long traceId,
long authorization)
{
handler.doExecuteSystemClient(traceId, authorization, sqlFormat);
}

@Override
public RisingwaveMacroState onCompletion(
long traceId,
Expand Down