Support http patch#1530
Merged
Merged
Conversation
…tIT.java, added test functions in test files fix the Support PATCH as HTTP method aklivity#1419
…les to is not updated, I merge branch 'develop' into support-http-patch to add my code to updated codebase.
I added test scripts and then see the develop branch has new code I didn't sync with, so I pull the updated develop branch code, and merge with my code # Please enter a commit message to explain why this merge is necessary,
jfallows
requested changes
Aug 12, 2025
Comment on lines
-137
to
+140
| "${net}/http.post.exchange.streaming/client", | ||
| "${app}/http.post.exchange.streaming/server" }) | ||
| public void httpPostExchangeWhenStreaming() throws Exception | ||
| "${net}/http.patch.exchange/client", | ||
| "${app}/http.patch.exchange/server" }) | ||
| public void httpPatchExchange() throws Exception |
Contributor
There was a problem hiding this comment.
I think you accidentally removed httpPostExchangeWhenStreaming() method when adding httpPatchExchange() method.
Please restore httpPostExchangeWhenStreaming() method, so the diff is just an add of httpPatchExchange() method, similar to other ConnectionManagementIT changes.
jfallows
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1419