Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
df07f72
Revert "Add http request validators feature flag (#472)"
attilakreiner Sep 28, 2023
f3e2245
WIP
attilakreiner Sep 28, 2023
7691312
fix
attilakreiner Oct 10, 2023
1f811c4
WIP
attilakreiner Oct 11, 2023
502db7f
WIP integation tests
attilakreiner Oct 13, 2023
330119d
WIP integration tests
attilakreiner Oct 16, 2023
2963d52
WIP h2 tests
attilakreiner Oct 18, 2023
4d9a19b
WIP h2 tests - content
attilakreiner Oct 19, 2023
dce5c70
WIP http/1.1 ITs - content
attilakreiner Oct 20, 2023
5e11f6f
fix
attilakreiner Oct 20, 2023
16af5e3
fix
attilakreiner Oct 21, 2023
4452d5b
WIP
attilakreiner Oct 25, 2023
eb9842b
fix method names
attilakreiner Oct 26, 2023
09e3087
WIP fix
attilakreiner Oct 26, 2023
e6ea82c
cleanup
attilakreiner Oct 26, 2023
dfcc7fa
fix h2 invalid test so all requests use the same connection
attilakreiner Oct 26, 2023
9a7f3c3
fix review items 1
attilakreiner Oct 27, 2023
215e72c
fix review items 2
attilakreiner Oct 27, 2023
cb5ffd8
fix review items 3
attilakreiner Oct 27, 2023
e95c006
Add server side for the invalid test h2
attilakreiner Oct 27, 2023
1296060
Fix invalid content in http/1.1 validation
attilakreiner Nov 2, 2023
769643b
Fix duplicate response header issue
attilakreiner Nov 2, 2023
a86eef4
fix NPE
attilakreiner Nov 3, 2023
345ded8
Revert "Fix duplicate response header issue"
attilakreiner Nov 3, 2023
9ffb3b1
send reset frame
attilakreiner Nov 3, 2023
7ee5980
fix
attilakreiner Nov 3, 2023
f57273f
fix 1
attilakreiner Nov 6, 2023
ad0c98f
fix 2
attilakreiner Nov 6, 2023
b5eded0
fix 3
attilakreiner Nov 6, 2023
ba32eb1
fix
attilakreiner Nov 7, 2023
3b4af62
fix 1
attilakreiner Nov 8, 2023
f3f0ee2
fix 2
attilakreiner Nov 8, 2023
5f6f544
fix 3
attilakreiner Nov 8, 2023
60d2ed5
fix 4
attilakreiner Nov 8, 2023
1cb75af
fix 5
attilakreiner Nov 8, 2023
0b5b33e
fix 6
attilakreiner Nov 8, 2023
d0ce297
fix 7
attilakreiner Nov 8, 2023
69812f7
fix 8
attilakreiner Nov 8, 2023
187e877
fix 9
attilakreiner Nov 8, 2023
cccd57f
fix 10
attilakreiner Nov 8, 2023
1b5a811
refactor HttpRequestType
attilakreiner Nov 8, 2023
3a5c307
refactor HttpRequestType 2
attilakreiner Nov 8, 2023
d748cca
WIP TreeMap
attilakreiner Nov 8, 2023
fc290e7
Add unit tests for urlDecodedComparator
attilakreiner Nov 8, 2023
dce06c6
fix 1
attilakreiner Nov 9, 2023
662fd09
fix 2
attilakreiner Nov 9, 2023
decd91d
fix 3
attilakreiner Nov 9, 2023
d41768f
PercentEncodableStringComparator 1
attilakreiner Nov 9, 2023
99718e1
PercentEncodableStringComparator 2
attilakreiner Nov 9, 2023
115da84
fix 4
attilakreiner Nov 9, 2023
be01927
WIP fix bug
attilakreiner Nov 10, 2023
b553ebe
fix 1
attilakreiner Nov 10, 2023
5cc0499
fix 2
attilakreiner Nov 10, 2023
0acab22
fix 1
attilakreiner Nov 11, 2023
12728d4
fix 2
attilakreiner Nov 13, 2023
d5e567c
fix 3
attilakreiner Nov 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix 3
  • Loading branch information
attilakreiner committed Nov 13, 2023
commit d5e567cf5fed1435589f7645e48572db1ed859d6
Original file line number Diff line number Diff line change
Expand Up @@ -1077,8 +1077,12 @@ else if (!isCorsRequestAllowed(server.binding, headers))
final String origin = policy == CROSS_ORIGIN ? headers.get(HEADER_NAME_ORIGIN) : null;

server.requestType = binding.resolveRequestType(beginEx);
error = server.onDecodeHeaders(server.routedId, route.id, traceId, exchangeAuth, policy, origin,
beginEx);
boolean headersValid = server.onDecodeHeaders(server.routedId, route.id, traceId, exchangeAuth,
policy, origin, beginEx);
if (!headersValid)
{
error = response400;
}
}
else
{
Expand Down Expand Up @@ -2242,7 +2246,7 @@ private void onDecodeCorsPreflight(
assert exchange == null;
}

private DirectBuffer onDecodeHeaders(
private boolean onDecodeHeaders(
long originId,
long routedId,
long traceId,
Expand All @@ -2252,7 +2256,6 @@ private DirectBuffer onDecodeHeaders(
HttpBeginExFW beginEx)
{
boolean headersValid = binding.validateHeaders(requestType, beginEx);
DirectBuffer error = null;
if (headersValid)
{
final HttpExchange exchange = new HttpExchange(originId, routedId, authorization, traceId, policy, origin);
Expand All @@ -2264,11 +2267,7 @@ private DirectBuffer onDecodeHeaders(

this.exchange = exchange;
}
else
{
error = response400;
}
return error;
return headersValid;
}

private void onDecodeHeadersOnly(
Expand Down