Skip to content

Fix producing empty message to retained topic #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfallows merged 1 commit into from
Nov 15, 2023
Merged

Fix producing empty message to retained topic #577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix producing empty message to retained topic
  • Loading branch information
@bmaidics
bmaidics committed Nov 15, 2023
commit e81c326c48456638f0c01086b34583ac42bf2921
15 changes: 9 additions & 6 deletions .../aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaCacheClientProduceFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,6 +801,8 @@ private void onClientInitialFlush(
error = ERROR_RECORD_LIST_TOO_LARGE;
}

markEntryDirty(traceId, stream.partitionOffset);

if (error != NO_ERROR)
{
stream.cleanupClient(traceId, error);
Expand Down Expand Up @@ -1361,12 +1363,12 @@ private void onClientInitialFlush(
assert acknowledge <= sequence;
assert sequence >= initialSeq;

if (reserved > 0)
{
initialSeq = sequence + reserved;
initialSeq = sequence + reserved;

assert initialAck <= initialSeq;
assert initialAck <= initialSeq;

if (reserved > 0)
{
if (initialSeq > initialAck + initialMax)
{
doClientInitialResetIfNecessary(traceId, EMPTY_OCTETS);
Expand All @@ -1377,9 +1379,10 @@ private void onClientInitialFlush(
{
fan.onClientInitialFlush(this, flush);
}
final int noAck = (int) (initialSeq - initialAck);
doClientInitialWindow(traceId, noAck, initialBudgetMax);
}

final int noAck = (int) (initialSeq - initialAck);
doClientInitialWindow(traceId, noAck, initialBudgetMax);
}

private void onClientInitialEnd(
Expand Down